HomeWildfire Games

Fix segfault in FCollada with Visual Studio > 2013. Bump the version of…

Description

Fix segfault in FCollada with Visual Studio > 2013. Bump the version of fcollada for macOS; Linux has no check. add native eol to the file.

Reviewed by: @wraitii
Comments by: @smiley

Differential Revision: https://code.wildfiregames.com/D2474

Event Timeline

This commit now requires audit.Nov 24 2020, 12:07 PM
Stan removed an auditor: Itms.Nov 24 2020, 2:18 PM
This commit no longer requires audit.Nov 24 2020, 2:18 PM
lyv added a comment.Nov 24 2020, 2:41 PM

Does FCollada have an upstream anymore? it would be in everyone's best interest to not have N different libraries.

Stan added a comment.Nov 24 2020, 2:42 PM

Not really. We will have the most patched version once the other patches I made about it will be merged. I checked all the public forks.

lyv added a comment.Nov 24 2020, 2:58 PM

https://github.com/rdb/fcollada if the maintainer is active, maybe that's a good candidate for a de facto upstream.