HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24323

Fix FCollada on platforms without ecvt
AuditedrP24323
Actions

Description

Fix FCollada on platforms without ecvt

Based on a patch by: @NF
Tested by: @nephele
Tested on FreeBSD, Windows, Kubuntu, macOS
Fixes: #1325
Differential Revision: https://code.wildfiregames.com/D2399

Details

Auditors
wraitii
Committed
StanDec 4 2020, 3:39 PM
Differential Revision
D2399: [BSD] Replace ecvt() in FCollada with something else
Parents
rP24322: Fix some compiler warnings. Use v141_xp toolset.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 14139
Build 29580: Post-Commit BuildJenkins
Build 29579: Post-Commit Build (macOS)Jenkins

Event Timeline

Stan committed rP24323: Fix FCollada on platforms without ecvt.Dec 4 2020, 3:39 PM
Stan added an edge: D2399: [BSD] Replace ecvt() in FCollada with something else.
Stan added subscribers: nephele, NF.
Herald added an auditor: Itms. · View Herald TranscriptDec 4 2020, 3:39 PM
This commit now requires audit.Dec 4 2020, 3:39 PM
Stan removed an auditor: Itms.Dec 4 2020, 3:43 PM
This commit no longer requires audit.Dec 4 2020, 3:43 PM
Harbormaster failed to build B14139: rP24323: Fix FCollada on platforms without ecvt!Dec 4 2020, 3:50 PM
wraitii raised a concern with this commit.Dec 4 2020, 7:15 PM
wraitii added a subscriber: wraitii.

Doesn't appear to compile on mac: https://jenkins.wildfiregames.com/job/macOS-all-bundles/15/

Need include guards around the new code.

This commit now has outstanding concerns.Dec 4 2020, 7:16 PM
Stan requested verification of this commit.Dec 4 2020, 8:02 PM
This commit now requires verification by auditors.Dec 4 2020, 8:02 PM
Stan mentioned this in rP24324: Revert Phab:rP24323 as the linking is broken.Dec 4 2020, 8:02 PM
lyv added a subscriber: lyv.Dec 4 2020, 9:38 PM

Ah, I see that this version got committed. Not a fan of the approach. But not like I am active on either end these days, so meh.

Stan added a comment.Dec 4 2020, 9:39 PM

And also got reverted ^^"

wraitii accepted this commit.Dec 5 2020, 8:19 AM

Reverted so it can't hurt us again :p

All concerns with this commit have now been addressed.Dec 5 2020, 8:19 AM

Changes (11)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
credits/
texts/
system/
libraries/
source/
fcollada/
include/
FUtils/
src/
FCollada/
FUtils/

rP24323

View Options

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json

Loading...
View Options

ps/trunk/binaries/system/Collada.dll

Loading...
View Options

ps/trunk/binaries/system/FCollada.dll

Loading...
View Options

ps/trunk/binaries/system/FCollada.pdb

Loading...
View Options

ps/trunk/binaries/system/FColladaD.dll

Loading...
View Options

ps/trunk/binaries/system/FColladaD.pdb

Loading...
View Options

ps/trunk/libraries/source/fcollada/build.sh

Loading...
View Options

ps/trunk/libraries/source/fcollada/include/FUtils/FUStringBuilder.hpp

Loading...
View Options

ps/trunk/libraries/source/fcollada/src/FCollada/FUtils/FUStringBuilder.hpp

Loading...
View Options

ps/trunk/libraries/source/fcollada/tests/

Loading...
View Options

ps/trunk/libraries/source/fcollada/tests/ecvt.c

Loading...
Wildfire Games · Phabricator