HomeWildfire Games

Correct some strings in the GUI.

Description

Correct some strings in the GUI.

Patch by: @Nescio
Differential Revision: D3007

Event Timeline

bb added a subscriber: bb.Dec 18 2020, 6:28 PM
bb added inline comments.
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt
3

up

Freagarach added inline comments.Dec 18 2020, 6:35 PM
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt
3

Agreed, but also not done in the previous touch.

bb added inline comments.Dec 18 2020, 6:36 PM
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt
3

feel free to yell there too

Freagarach added inline comments.Dec 18 2020, 6:37 PM
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt
3

Nah, I'll update when I get back.

vladislavbelov added inline comments.
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Replaces numbers by words in near text seems strange to me.

Nescio added inline comments.Jan 14 2021, 1:05 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Numbers (integers) from zero to twenty ought to be written out in proper sentences, e.g. “you have three choices” is preferable to “you have 3 choices”.

vladislavbelov added inline comments.Jan 14 2021, 1:18 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Then why they weren't replaced in labels?

Also https://www.grammarly.com/blog/when-to-spell-out-numbers/ (and many others) states that numbers in texts (in some places mentioned as technical) are numbers until ten.

Nescio added inline comments.Jan 14 2021, 1:44 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Then why they weren't replaced in labels?

The labels are abbreviations, not proper sentences.

Also https://www.grammarly.com/blog/when-to-spell-out-numbers/ (and many others) states that numbers in texts (in some places mentioned as technical) are numbers until ten.

It's a bit more complicated (and a matter of taste), the specific recommendations vary a bit from style guide to style guide, e.g.:

Personally I prefer:

  • write it out when it's one word (hence zero to twenty; also e.g. fifty, a thousand, a million);
  • when it's two words or hyphenated, either is fine (e.g. forty-two vs 42);
  • when it's longer than that, use digits (one hundred and twenty-three is much less readable than 128).

Of course, digits should always be used for things that are measured instead of counted, hence always 5 metres (or 5 m), never five metres.
And when two different numbers appear next to each other, one should be written out, the other in digits, e.g. “three 5-year-old children”.
I should probably update https://trac.wildfiregames.com/wiki/EnglishStyleGuide on this.

Nescio added inline comments.Jan 14 2021, 2:13 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Also https://www.grammarly.com/blog/when-to-spell-out-numbers/

It actually says:

  • “It is generally best to write out numbers from zero to one hundred in nontechnical writing.”

and:

  • “Numbers can disrupt readability in a paragraph, so for most writing purposes, it is best to flex those fingers and type out numbers less than 101 as fully spelled words.”

Anyway, the most important thing is consistency. Having “two”, “four”, “eight” in lines 126, 127, 128, respecitively, but “16” in line 129 looks poorly.

Stan added a subscriber: Stan.Jan 14 2021, 2:21 PM
Stan added inline comments.
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

I suppose aura tooltips are technical? hence the +20% there? instead of a proper sentence

Nescio added inline comments.Jan 14 2021, 2:26 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Tooltips are proper sentences, but modifications (and percentages) are things that are calculated, not counted, hence digits, not words.

vladislavbelov added inline comments.Jan 14 2021, 2:51 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

I believe that in case of such kind of technical information we need to use numbers instead of words. Like it's done for gameplay numbers (+10 maximum population limit).

Nescio added inline comments.Jan 14 2021, 3:19 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Both aura tooltips and game setting tooltips are user-facing texts written for a general audience (not all 0 A.D.-players are professional programmers), not technical documentation for specialists who want to understand the inner workings.

The phrase “two samples per pixel” seems countable to me, hence why I wrote out the 2.

vladislavbelov added inline comments.Jan 14 2021, 3:23 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

Actually in that case it's more about technical details rather than something a general audience for.

Nescio added inline comments.Jan 14 2021, 3:38 PM
/ps/trunk/binaries/data/mods/public/gui/options/options.json
126–129

If you think it's important, feel free to revert; I was just explaining why I changed it.