Description
Details
- Committed
Freagarach Dec 17 2020, 12:47 PM - Differential Revision
- D3007: [gui] correct some strings
- Parents
- rP24400: Treat code between `[]` and `{}` as one blob for translations.
- Branches
- Unknown
- Tags
- Build Status
Buildable 14424 Build 30550: Post-Commit Build Jenkins Build 30549: Post-Commit Build (macOS) Jenkins
Event Timeline
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt | ||
---|---|---|
3 | up |
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt | ||
---|---|---|
3 | Agreed, but also not done in the previous touch. |
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt | ||
---|---|---|
3 | feel free to yell there too |
/ps/trunk/binaries/data/mods/public/gui/prelobby/common/terms/Terms_of_Service.txt | ||
---|---|---|
3 | Nah, I'll update when I get back. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | Replaces numbers by words in near text seems strange to me. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | Numbers (integers) from zero to twenty ought to be written out in proper sentences, e.g. “you have three choices” is preferable to “you have 3 choices”. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | Then why they weren't replaced in labels? Also https://www.grammarly.com/blog/when-to-spell-out-numbers/ (and many others) states that numbers in texts (in some places mentioned as technical) are numbers until ten. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 |
The labels are abbreviations, not proper sentences.
It's a bit more complicated (and a matter of taste), the specific recommendations vary a bit from style guide to style guide, e.g.:
Personally I prefer:
Of course, digits should always be used for things that are measured instead of counted, hence always 5 metres (or 5 m), never five metres. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 |
It actually says:
and:
Anyway, the most important thing is consistency. Having “two”, “four”, “eight” in lines 126, 127, 128, respecitively, but “16” in line 129 looks poorly. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | I suppose aura tooltips are technical? hence the +20% there? instead of a proper sentence |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | Tooltips are proper sentences, but modifications (and percentages) are things that are calculated, not counted, hence digits, not words. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | I believe that in case of such kind of technical information we need to use numbers instead of words. Like it's done for gameplay numbers (+10 maximum population limit). |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | Both aura tooltips and game setting tooltips are user-facing texts written for a general audience (not all 0 A.D.-players are professional programmers), not technical documentation for specialists who want to understand the inner workings. The phrase “two samples per pixel” seems countable to me, hence why I wrote out the 2. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | Actually in that case it's more about technical details rather than something a general audience for. |
/ps/trunk/binaries/data/mods/public/gui/options/options.json | ||
---|---|---|
126–129 | If you think it's important, feel free to revert; I was just explaining why I changed it. |