Add a function to query a global object, including JS classes, from C++
rP24406
Actions

Description

Add a function to query a global object, including JS classes, from C++

The latter are not properties of the global object but stored within the global lexical environment.
This is not currently needed, but will be useful for future diffs.
Update Vector2D/3D querying.

Taken from D2746

Details

Committed

wraitii

Dec 17 2020, 6:51 PM

Parents

rP24405: Only create construction previews when committed.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 14433
Build 30577: Trigger Windows Autobuild
Build 30576: Post-Commit Build	Jenkins
Build 30575: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP24406: Add a function to query a global object, including JS classes, from C++.Dec 17 2020, 6:51 PM

Harbormaster failed to build B14433: rP24406: Add a function to query a global object, including JS classes, from C++!Dec 17 2020, 7:06 PM

vladislavbelov added a subscriber: vladislavbelov.Dec 17 2020, 9:45 PM

vladislavbelov added inline comments.

/ps/trunk/source/scriptinterface/ScriptInterface.cpp
722	Forgotten debug code.
723	I suppose it should be `JS_GlobalLexicalEnvironment(rq.glob)` according to mozilla usages.
/ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp
161	The unused variable wasn't removed.
197	The unused variable wasn't removed.