HomeWildfire Games

Let units take time actual time for turning while moving. This limits the…

Description

Let units take time actual time for turning while moving. This limits the possibility of "dancing" (making short moves to avoid being hit by arrows) beyond only patrolling.

Reviewed By: wraitii
Gameplay Tests By: FeldFeld
Comments By: Freagarach, Angen

Differential Revision: D2837
refs: #5106

Event Timeline

wraitii added inline comments.
/ps/trunk/source/simulation2/components/CCmpUnitMotion.cpp
1018

The fact that it breaks kind of breaks L910 that resets FailedPathComputation to 0, because we can't be obstructed while turning, but it's also not really an indicator that the unit managed to move.

It's theoretically possible to get units stuck in a "vibrato" motion that never ends because of this, though I've only reproduced it with D3203 so far.

borg- added a subscriber: borg-.Dec 22 2020, 1:18 PM

Is it possible to reduce this "delay" a little? Cavalry mainly seems to have been very slow.

borg- added a comment.EditedDec 23 2020, 3:10 AM

@Stan @bb @wraitii, I found a bug. If you click repeatedly on the same location, the units move very slowly, when you stop clicking, they return to normal speed,

borg- added a subscriber: Stan.Dec 23 2020, 11:47 AM
bb added a comment.Dec 23 2020, 3:14 PM

Is it possible to reduce this "delay" a little? Cavalry mainly seems to have been very slow.

Not sure what you mean with "delay". Cavalry indeed turns slower than infantry, which seems very realistic to me.

@Stan @bb @wraitii, I found a bug. If you click repeatedly on the same location, the units move very slowly, when you stop clicking, they return to normal speed,

Shift Clicking will give several orders, so if you shift click on closeby locations, your unit will move between these locations, and this indeed takes some time. But that isn't changed by this patch...

borg- added a comment.EditedDec 23 2020, 3:27 PM

Shift Clicking will give several orders, so if you shift click on closeby locations, your unit will move between these locations, and this indeed takes some time. But that isn't changed by this patch...

I'm not talking about shift + click. Slowness occurs with normal clicks repeatedly anywhere on the map, units reduce movement speed in half.

bb added a comment.Dec 23 2020, 3:54 PM

hmm ok, see the issue: clickspam around a unit to another side of an obstruction. The problem here is that we don't know the actual path yet when we start to move. For the first turn we just try to move in the correct direcion, which can be wrong. Hence we try turning there too, which wastes some time, and thus we move slower/not at all.

Making a ticket https://trac.wildfiregames.com/ticket/5896.

ValihrAnt raised a concern with this commit.Dec 24 2020, 9:50 PM
ValihrAnt added a subscriber: ValihrAnt.

Me and borg had a quick test game on r24446 and encountered some issues. The biggest one was with formation and unit rotation. In the fight starting at min 5 the archers entered a formation. Whenever a soldier from the formation was killed the archers went to regroup and due to the rotation often lost out on multiple seconds of attacking. Over a fight this adds up to a huge amount and was probably the deciding factor in him losing that battle.
Secondly, I had an issue in get my wardog unstuck from between the berry gatherers. The reason is probably what borg mentioned earlier that spam clicking doesn't work and considering that, at least in my case, the method for getting units unstuck is to spam click small distances ahead I was unable to free it. So I had to move my berry gatherers away for a second.
In general, we both came to the conclusion that the current amount of rotation feels too much and too clunky. I think a bit of rotation is good, but it needs to not interfere with gameplay too much and keep it feeling smooth. Now whether that is achievable without leaving dancing alive I don't know but it could also be tried in combination with the units have some bit of 'aimbot'.

This commit now has outstanding concerns.Dec 24 2020, 9:50 PM
borg- added a comment.EditedDec 24 2020, 10:02 PM

In Second game, my dog cant attack valirhant Priest.

With rotation, game does not keep up with the speed of reasoning. when I click to attack, unit still comming back, it is impossible to attack and run.

I think MP long turns make the problem worse than in SP. I would raise the turn rate of infantry from 6 to 10.

bb added a comment.Dec 25 2020, 2:00 PM

Yeah formations are failing on member death. This patch only highlights the issue, see D3236. We should fix that.

The spamclick issue, found by borg is fundamentally different compared to any slowdown on shift spamclicking. I guess the latter can be somewhat reduced by the acceleration patch.

bb added a comment.Dec 25 2020, 2:15 PM

Also for the shift laggyness, there is D3230, ought to be committed soonish

Stan added a comment.Jan 13 2021, 12:50 AM

Is it good now?

Angen added a subscriber: Angen.Feb 8 2021, 8:02 PM
Angen added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/Formation.js
865

parameter is totally redundant and confusing now

This commit no longer requires audit.Apr 21 2021, 11:11 AM