HomeWildfire Games

Map browser, used in the gamesetup and in the main menu.

Description

Map browser, used in the gamesetup and in the main menu.

This grid-based system allows browsing all available maps at a glance, encouraging more diversity and making it nicer to pick a map.

Moves the mapCache and the map filters controller to the gui maps/ folders, and include that folder where it is used, instead of them being in common/ or the gamesetup.

Comments By: Freagarach

Patch By: Nani (reworked by elexis then wraitii)

Fixes #5315 (though further work, such as proper scrolling, would be nice).

Differential Revision: https://code.wildfiregames.com/D1703

Event Timeline

Stan added a subscriber: Stan.Dec 31 2020, 4:21 PM

Not sure I should raise a concern but

wraitii added a comment.EditedDec 31 2020, 4:28 PM
In rP24459#46732, @Stan wrote:

I'll look into it. Seems like Resize isn't triggering everything it should.

  • The GUI says the hotkey is M while it should show , on AZERTY Keyboards

That is weirder...

In rP24459#46732, @Stan wrote:

Not on Linux :)

Stan added a comment.Jan 1 2021, 5:41 PM

Not on Linux :)

Well it happens on Linux too for me. No GL error though.

In rP24459#46732, @Stan wrote:
  • Resizing the windows triggers a GL error

Only when the resize is down and substantial enough to trigger it, and it sill can happen with the map browser closed on my computer... I'm not entirely sure I can avoid it with the current GUI code TBH.

I think it's actually perfectly functional, just a bit unexpected. It tries to keep the # of columns, not the size of images.

  • The GUI says the hotkey is M while it should show , on AZERTY Keyboards

Fixed in D3277

Stan added a comment.EditedJan 2 2021, 11:30 AM

I think it's actually perfectly functional, just a bit unexpected. It tries to keep the # of columns, not the size of images.

I would agree if it didn't say page 1/8 - 1/10 while we go from 6 images per page to 2

2*10 = 20 - 6*8 = 48 :)

In rP24459#46803, @Stan wrote:

I would agree if it didn't say page 1/8 - 1/10 while we go from 6 images per page to 2

2*10 = 20 - 6*8 = 48 :)

Not how the pages work (though I agree it's kinda confusing, but I couldn't find clearer wording). The pages are actually the # of scrollable rows, so it actually does add only 2 new rows.

Imarok raised a concern with this commit.Jan 12 2021, 6:25 PM
Imarok added a subscriber: Imarok.

I think there is something wrong in fullscreen.
I'd expect to see 9 or 12 maps in fullscreen and not only two:

This commit now has outstanding concerns.Jan 12 2021, 6:25 PM
Stan added a comment.EditedJan 12 2021, 6:51 PM

Apparently it's a "feature" (the problem comes when you switch between fullscreen and windowed) If you load the gamesetup in fullscreen it works. See the images i posted above.

wraitii requested verification of this commit.Jan 12 2021, 6:54 PM

Yeah as discussed on IRC, this is working as designed, though it looks a bit odd. The # of column is static.
I've created #5910, I don't think it warrants more at the moment?

This commit now requires verification by auditors.Jan 12 2021, 6:54 PM
Imarok resigned from this commit.Jan 12 2021, 8:19 PM

Is only an issue when resizing the window while in gamesetup.
So it is still kind of a bug but not as severe as thought.

This commit no longer requires audit.Jan 12 2021, 8:19 PM