Which point is your concern precisely?

In rP24492#46831, @Nescio wrote:

• None of the civ-specific structures actually shows up in the civilization overviews (see D2733 for all currently buildable unique structures).

That is where your patch was for :)

In rP24492#46831, @Nescio wrote:

• All civs have a wonder and they're all statistically identical, therefore it's unnecessary to include them in the civilization overviews.

This is a matter of preference, IMHO.

In rP24492#46831, @Nescio wrote:

• Heroes display their identity unit tooltips, i.e. bonus attack multiplier, which is not terribly important; their aura descriptions are more important.

Agreed, feel free to improve ;)

In rP24492#46831, @Nescio wrote:

• Should catafalque auras be included?

No (D294).

In rP24492#46831, @Nescio wrote:

• Should both the specific (non-English) and generic (English) names be displayed in the civilization overviews?

Yes.

In rP24492#46831, @Nescio wrote:

• The right column displays only three hero names, whereas the central columns displays both special technologies and special structures; because there tend to be more of these (see e.g. kush or pers), I'd recommend moving structures to the right column.
• The four columns have unequal widths; changing that to 30% each would probably look better.

Feel free to improve, I guess.

Which point is your concern precisely?

The first point is most concerning: prior to this patch civ overview pages listed civ specific structures, now they no longer do. Doing a grep -r SpecialBuilding in the simulation folder returns zero occurrences.

This is a matter of preference, IMHO.

Perhaps, but why should wonders be included? They weren't in the past, and other structures available to all civs aren't included either.

In rP24492#46831, @Nescio wrote:

• The right column displays only three hero names, whereas the central columns displays both special technologies and special structures; because there tend to be more of these (see e.g. kush or pers), I'd recommend moving structures to the right column.

(Formerly, the hero description took quite some space (rP24493#46757).)

It did not: the description (what is displayed) is something different than the history (what is hidden in a pop-up). Here's how it looks like in A23:

Ah, my mistake then.

The Special Buildings not actually showing up is an oversight on my part - somehow I had missed that you (and bb) removed the SpecialBuilding class back in July. I shall try to work with you to get D2733 done and committed, which should remedy that.

Much of the other suggestions are more about adding content to, or changing the visuals and/or layout of the civinfo page, all of which is out of the intended scope of this commit. The intent was to swap the {civ}.json-sourced strings for ones taken from entity/technology templates, not to change what or how things should be displayed. (Any entries appearing/disappearing was a side-effect.)

However, now that this commit is in I feel it is probably time to seriously consider redesigning the layout of the page (something I've been wanting to do since 2015), which hopefully will satisfy the visuals/layout portion of your raised Concern. Give me a few days to update things locally, and then I should have some screenshots of potential directions a redesign might take.

The first point is the most important and the reason I raised a concern. Points two and five are things that are done differently now than they were prior to this commit. Points three and four are questions, but yes, out of scope. I made a patch addressing points six and seven: D3295, which merely tweaks the current design.
I'm certainly looking forward to your fundamental redesign of the layout!

The problem has been solved by D2733/rP24535, civ-specific structures are again properly displayed in the civilization overviews.

In rP24492#46874, @Nescio wrote:

I'm certainly looking forward to your fundamental redesign of the layout!

🚧 M1 🚧