HomeWildfire Games

Hint the location for "You have been attacked" notifications
AuditedrP24565

Description

Hint the location for "You have been attacked" notifications

Icon edited by Stan.
Fixes: #5132
Differential Revision: https://code.wildfiregames.com/D1461

Event Timeline

Silier added a subscriber: Silier.EditedJan 14 2021, 11:32 AM

ERROR: Errors executing script event "Press"

ERROR: JavaScript error: gui/session/chat/ChatMessageFormatSimulation.js line 28 position is null parse/<.callback</<@gui/session/chat/ChatMessageFormatSimulation.js:28:6

I think it is because entity already died

(One can sent the position from AttackDetection.js. (Don't need to get the ent-state then.) Although that may cause the entity to have left the screen already.)

Silier raised a concern with this commit.Jan 15 2021, 7:54 PM

got today again so raising concern

This commit now has outstanding concerns.Jan 15 2021, 7:54 PM
In rP24565#47420, @Angen wrote:

ERROR: Errors executing script event "Press"

ERROR: JavaScript error: gui/session/chat/ChatMessageFormatSimulation.js line 28 position is null parse/<.callback</<@gui/session/chat/ChatMessageFormatSimulation.js:28:6

I think it is because entity already died

Thank you for testing.
I thought I tested with a dead unit, but I'll look into it.

(One can sent the position from AttackDetection.js. (Don't need to get the ent-state then.) Although that may cause the entity to have left the screen already.)

Not sure you have access to that from within the gui code.

Could any of you two reproduce the issue consistently?

Ignore me ^^'

Why should I? ;P

Could any of you two reproduce the issue consistently?

I haven't been able to reproduce it in any way actually.

Why should I? ;P

It looks like I can't read properly.

Silier added a subscriber: wraitii.EditedJan 16 2021, 8:58 AM

consistently no, but kind of. It happend in game with @wraitii yesterday when he destroyed my storehouse and then I clicked on the message not sure what else happend in the meantime, he uploaded replay on some diff.

would be here https://code.wildfiregames.com/D3373

This commit introduced a bug that created blank lines.
It was fixed by rP24671.

Imarok requested verification of this commit.Jan 20 2021, 10:01 PM

position issue fixed in rP24736

This commit now requires verification by auditors.Jan 20 2021, 10:01 PM
Silier accepted this commit.Jan 21 2021, 7:38 PM

cannot reproduce anymore

All concerns with this commit have now been addressed.Jan 21 2021, 7:38 PM