HomeWildfire Games

Address concerns in rP23917 (RL interface)

Description

Address concerns in rP23917 (RL interface)

Fixes rP23917.

This:

  • Puts RL code under the RL namespace to avoid name collisions
  • Avoids usage of new/delete
  • Adds more documentation
  • Does general cleanup (const-correctness, move semantics, argument types, early returns...)

Patch by: irishninja

Comments by: Vladislavbelov, wraitii

Differential Revision: https://code.wildfiregames.com/D2947

Event Timeline

Missed years.

/ps/trunk/source/ps/scripting/JSInterface_Game.cpp
29

Wrong order.

/ps/trunk/source/rlinterface/RLInterface.cpp
28

Wrong order.

152–155

Still duplicated allocation. As well as below.

186

Should be inside the if.

192

std::move.

/ps/trunk/source/rlinterface/RLInterface.h
72–79

Very unsafe logic with locks.