HomeWildfire Games

Fix lobby gamelist issues when clients join and leave a match.

Description

Fix lobby gamelist issues when clients join and leave a match.

This patch will:

  • Pass gameRegisterStanza to playerAssignmentsControl constructor.
  • Remove handlers for onClientJoin and onClientLeave from gameRegisterStanza class.
  • Call gameRegisterStanza method sendImmediately only once after all handlers have run and after updating g_PlayerAssignments .
  • Remove from gameRegisterStanza the dependency on playerAssignmentsControl since the onClientJoin and onClientLeave handlers are removed.

Reviewers: Angen, wraitii

Accepted By: wraitii

Trac Tickets: #5929, #5933

Differential Revision: https://code.wildfiregames.com/D3406

Event Timeline

Angen raised a concern with this commit.Feb 13 2021, 3:15 PM
Angen added a subscriber: Angen.
Angen added inline comments.
/ps/trunk/binaries/data/mods/public/gui/gamesetup/Controls/PlayerAssignmentsControl.js
108

this is not a function :)

This commit now has outstanding concerns.Feb 13 2021, 3:15 PM
Angen resigned from this commit.Feb 13 2021, 4:49 PM
This commit no longer requires audit.Feb 13 2021, 4:49 PM
Angen removed an auditor: Angen.Feb 13 2021, 4:49 PM