HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24732

Removes shader code duplication to calculate LOS.
AuditedrP24732
Actions

Description

Removes shader code duplication to calculate LOS.

Tested By: Stan

Differential Revision: https://code.wildfiregames.com/D3428

Details

Auditors
Freagarach
Committed
vladislavbelovJan 20 2021, 7:46 PM
Differential Revision
D3428: Removes shader code duplication to calculate LOS
Parents
rP24731: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15297
Build 33309: Trigger Windows Autobuild
Build 33308: Post-Commit BuildJenkins
Build 33307: Post-Commit Build (macOS)Jenkins

Event Timeline

vladislavbelov committed rP24732: Removes shader code duplication to calculate LOS..Jan 20 2021, 7:46 PM
vladislavbelov added an edge: D3428: Removes shader code duplication to calculate LOS.
Harbormaster completed building B15297: rP24732: Removes shader code duplication to calculate LOS..Jan 20 2021, 9:38 PM
vladislavbelov mentioned this in rP24739: Refactors water_high shader, cleanups water changes after rP24732..Jan 20 2021, 11:36 PM
Freagarach raised a concern with this commit.EditedJan 21 2021, 10:36 AM
Freagarach added a subscriber: Freagarach.

I wanted to test, but got distracted.

Water is black for me after this revision.

[EDIT]: Lowest water quality settings.

This commit now has outstanding concerns.Jan 21 2021, 10:36 AM
vladislavbelov mentioned this in rP24746: Fixes simple ARB water after rP24732. Completely removing losMatrix usages..Jan 21 2021, 12:35 PM
vladislavbelov requested verification of this commit.Jan 21 2021, 12:36 PM
This commit now requires verification by auditors.Jan 21 2021, 12:36 PM
Freagarach accepted this commit.Jan 21 2021, 12:40 PM

Yeah, I can swim in blue water again! (My concern has been fixed.)

All concerns with this commit have now been addressed.Jan 21 2021, 12:40 PM

Changes (20)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
shaders/
glsl/
common/
source/
ps/
renderer/

rP24732

View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/common/los_fragment.h

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/common/los_vertex.h

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/model_common.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/model_common.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/model_water.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/model_water.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/model_waterfall.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/model_waterfall.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/overlayline.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/overlayline.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/particle.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/particle.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/terrain_common.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/terrain_common.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_high.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_high.vs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_simple.fs

Loading...
View Options

ps/trunk/binaries/data/mods/public/shaders/glsl/water_simple.vs

Loading...
View Options

ps/trunk/source/ps/CStrInternStatic.h

Loading...
View Options

ps/trunk/source/renderer/TerrainRenderer.cpp

Loading...
Wildfire Games · Phabricator