HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24870

Switches decals to VBChunk to reduce the number of state changes.
rP24870
Actions

Description

Switches decals to VBChunk to reduce the number of state changes.

Also allows to use compressed vertex formats in future.

Tested By: Stan

Differential Revision: https://code.wildfiregames.com/D3553

Details

Committed
vladislavbelovFeb 11 2021, 12:48 AM
Differential Revision
D3553: Switches decals to VBChunk to make it using compressed vertices in future
Parents
rP24869: Fix no-formation orders after several formation orders.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15640
Build 34436: Trigger Windows Autobuild
Build 34435: Post-Commit BuildJenkins
Build 34434: Post-Commit Build (macOS)Jenkins

Event Timeline

vladislavbelov committed rP24870: Switches decals to VBChunk to reduce the number of state changes..Feb 11 2021, 12:48 AM
vladislavbelov added an edge: D3553: Switches decals to VBChunk to make it using compressed vertices in future.
Harbormaster completed building B15640: rP24870: Switches decals to VBChunk to reduce the number of state changes..Feb 11 2021, 1:45 AM
wraitii raised a concern with this commit.Feb 17 2021, 9:23 PM
wraitii added a subscriber: wraitii.
wraitii added inline comments.
/ps/trunk/source/renderer/DecalRData.cpp
303

This assertion appears to crash every now and then.

This commit now has outstanding concerns.Feb 17 2021, 9:23 PM
vladislavbelov added inline comments.Feb 17 2021, 10:31 PM
/ps/trunk/source/renderer/DecalRData.cpp
303

It means that m_Decal->CalcVertexExtents returned empty rectangle. So the broken code isn't here, but inside m_Decal.

vladislavbelov mentioned this in D3578: Do not generate render data in case Decal calculated wrong coordinates.Feb 17 2021, 11:05 PM
vladislavbelov requested verification of this commit.Feb 18 2021, 10:11 PM
This commit now requires verification by auditors.Feb 18 2021, 10:11 PM
wraitii removed an auditor: wraitii.Feb 18 2021, 10:13 PM
This commit no longer requires audit.Feb 18 2021, 10:13 PM

Changes (3)

PathSize
ps/
trunk/
source/
renderer/

rP24870

View Options

ps/trunk/source/renderer/DecalRData.cpp

Loading...
View Options

ps/trunk/source/renderer/DecalRData.h

Loading...
View Options

ps/trunk/source/renderer/PatchRData.cpp

Loading...
Wildfire Games ยท Phabricator