Diffusion 0 A.D. Public Repository rP24969

Introduce C++ templates replacements for DEFINE_INTERFACE_X and…
rP24969
Actions

Description

Introduce C++ templates replacements for DEFINE_INTERFACE_X and RegisterFunction macros

The new methods:

aren't included in ScriptInterface.h directly, lightening that header
don't use boost CPP
don't need argument types or number or constness to be specified
can work with object methods somewhat transparently
support optional cmptPrivate (allowing removal of many UNUSED macro)
support optional const ScriptRequest&, which is safer.

This first diff changes only some of the JSI files & the component manager. Further diffs will update other files and finally delete the current code.

Differential Revision: https://code.wildfiregames.com/D2818

Details

Committed

wraitii

Mar 1 2021, 9:52 PM

Differential Revision

D2818: Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code

Parents

rP24968: Guarantees no memset for allocation of DynamicArena::Block

Branches

Unknown

Tags

Unknown

Build Status

Buildable 15895
Build 35253: Trigger Windows Autobuild
Build 35252: Post-Commit Build	Jenkins
Build 35251: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP24969: Introduce C++ templates replacements for DEFINE_INTERFACE_X and….Mar 1 2021, 9:52 PM

wraitii added an edge: D2818: Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code.

Harbormaster completed building B15895: rP24969: Introduce C++ templates replacements for DEFINE_INTERFACE_X and….Mar 1 2021, 11:02 PM

Can you fix all those warnings? I fixed everything for A24 ^^"

Gravité	Code	Description	Projet	Fichier	Ligne	État de la suppression
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\simulation2\system\ComponentManager.cpp)	simulation2	c:\dev\trunk\source\scriptinterface\functionwrapper.h	225	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\GameSetup\HWDetect.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	216	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\GameSetup\HWDetect.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	217	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\GameSetup\HWDetect.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	225	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Console.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	216	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Console.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	217	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Console.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	225	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Hotkey.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	216	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Hotkey.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	217	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Hotkey.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	225	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Mod.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	216	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Mod.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	217	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\ps\scripting\JSInterface_Mod.cpp)	engine	c:\dev\trunk\source\scriptinterface\functionwrapper.h	225	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\simulation2\system\ComponentManager.cpp)	simulation2	c:\dev\trunk\source\scriptinterface\functionwrapper.h	216	
Avertissement	C4068	pragma inconnu (compilation du fichier source ..\..\..\source\simulation2\system\ComponentManager.cpp)	simulation2	c:\dev\trunk\source\scriptinterface\functionwrapper.h	217

Mh, sorry 'bout that, I missed that those were related to this diff when checking the warnings. I'll fix it.

wraitii mentioned this in D3623: Fix MSVC unknown pragma warning.Mar 2 2021, 9:40 AM

wraitii mentioned this in rP24976: Fix MSVC unknown pragma warning.Mar 2 2021, 4:00 PM

wraitii mentioned this in rP24983: Refactor all usage of RegisterFunction to ScriptFunction::Register.Mar 2 2021, 9:01 PM

wraitii mentioned this in D3912: Replace ScriptInterface::Call* with new ScriptFunction functions.May 1 2021, 10:03 AM

wraitii mentioned this in rP25354: Replace ScriptInterface::Call* with new ScriptFunction functions.May 1 2021, 4:05 PM