Description
Details
- Committed
Freagarach Mar 3 2021, 8:47 AM - Differential Revision
- D3303: Split treasures from ResourceSupply.
- Parents
- rP24988: [Windows] Automated build.
- Branches
- Unknown
- Tags
- Build Status
Buildable 15953 Build 35452: Post-Commit Build Jenkins Build 35451: Post-Commit Build (macOS) Jenkins
Event Timeline
It seems TreasureCollecter should TreasureCollector the former doesn't seem to be an english word at all. Could also have been TreasureGatherer.
Oops, you're right!
Well, I've mostly chosen the Collect[e|o]r for its explicit difference from resource gathering.
| /ps/trunk/binaries/data/mods/public/simulation/components/Treasure.js | ||
|---|---|---|
| 73 | This is wrong. | |
Another one.
Order missing for formationcontroller causing formationcontroller going to individual state so breaking it.
https://wildfiregames.com/forum/topic/39973-a25-feedbacks-from-testing/page/15/?tab=comments#comment-444979
Steps to reproduce:
- make formation
- order to collect treasure
- ignored because formation controller went to individual state
bug 3.1 formation controller is out of formation controller state
bug 3.2 members are not responding until reformed with new formation
UnitAI.prototype.GetBestAttackAgainst = function(target, allowCapture)
{
var cmpAttack = Engine.QueryInterface(this.entity, IID_Attack);
if (!cmpAttack)
return undefined;
if (this.IsFormationController()) {
error("Formation controller in GetBestAttackAgainst()");
return undefined;
}
return cmpAttack.GetBestAttackAgainst(target, allowCapture);
};will result in ERROR: Formation controller in GetBestAttackAgainst()
