HomeWildfire Games
Diffusion 0 A.D. Public Repository rP25040

Clean up RemoveBatch -> RemoveItem code in ProductionQueue.
rP25040
Actions

Description

Clean up RemoveBatch -> RemoveItem code in ProductionQueue.

  • Rename RemoveBatch to RemoveItem.
  • Refactor that function. (Don't clear the cached entities when *any* item is removed.)

Fixes the bug that the training is still blocked when a tech is the next in the queue and the blocking item is removed.

Based on a patch by: @Polakrity
Differential revision: D1843
Comments by: @Angen, @bb

Details

Committed
FreagarachMar 12 2021, 9:45 AM
Differential Revision
D1843: ProductionQueue - Refactor the remove item function
Parents
rP25039: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 16115
Build 36006: Post-Commit BuildJenkins
Build 36005: Post-Commit Build (macOS)Jenkins

Changes (3)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/
tests/
helpers/

rP25040

View Options

ps/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_ProductionQueue.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Commands.js

Loading...
Wildfire Games ยท Phabricator