Diffusion 0 A.D. Public Repository rP25096

Further gamesetup fixes & tweaks.
rP25096
Actions

Tags

None

Subscribers

None

Description

Further gamesetup fixes & tweaks.

Player assignment still had some trouble. This cleans things up by moving a little more logic in the controller & fixing other usage.
- As a consequence, in MP, if the host swaps two player, the change will take a few frames to register. It shouldn't be too much of a problem in practice.
- Fix issues with AI being assigned to player slots for joiners.
Fix issues with similar color not being correctly picked when swapping a map.
Fix issues with rating & locked team settings.

Reported by: langbart

Differential Revision: https://code.wildfiregames.com/D3723

Details

Committed

Mar 21 2021, 2:09 PM

Differential Revision

D3723: Further gamesetup fixes & tweaks.

Parents

rP25095: Color incompatible mods and add filter

Branches

Unknown

Tags

Unknown

Build Status

Buildable 16316
Build 36681: Post-Commit Build	Jenkins
Build 36680: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25096: Further gamesetup fixes & tweaks..Mar 21 2021, 2:09 PM

wraitii added an edge: D3723: Further gamesetup fixes & tweaks..

Harbormaster completed building B16316: rP25096: Further gamesetup fixes & tweaks..Mar 21 2021, 2:26 PM

wraitii mentioned this in D3724: Fix AI+Player from persistent settings (again).Mar 22 2021, 1:58 PM

wraitii mentioned this in rP25103: Fix AI+Player from persistent settings (again).Mar 22 2021, 5:57 PM

Changes (5)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

gamesettings/

attributes/

gamesetup/

Controls/

PlayerAssignmentsControl.js

Pages/

GameSetupPage/

GameSettings/

PerPlayer/

Dropdowns/

PlayerAssignment.js

Single/

Checkboxes/

rP25096

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/PlayerColor.js

Loading...

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/Rating.js

Loading...

ps/trunk/binaries/data/mods/public/gui/gamesetup/Controls/PlayerAssignmentsControl.js

Loading...

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/Dropdowns/PlayerAssignment.js

Loading...

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Checkboxes/LockedTeams.js

Loading...