HomeWildfire Games

GameSetup GUI cleanup - Renaming.

Description

GameSetup GUI cleanup - Renaming.

  • rename 'Controls' class to 'Controllers' to avoid ambiguity and mimic MVC lingo.
  • rename GameRegisterStanza into LobbyGameRegistration, and make it explicitly a controller.
  • rename GameSettingsFile to PersistentMatchSettings & move it to its own folder (since it could be reused independently of the controllers)
  • remove the StartGameController & move launchGame to the GameSettingsController (simplifies the control flow)
  • the GUI Object "setupWindow" was actually the GameSettingsPage, this is corrected.
  • the LoadingPage was showing the GameSettingsPage -> in the current code, it makes more sense to have both handle their own visibility.
  • make the NetMessages class independent of other gamesetup logic, so that it can be reused by other code. Remove the custom XML object.

Differential Revision: https://code.wildfiregames.com/D3719

Event Timeline

Stan raised a concern with this commit.Aug 9 2021, 4:52 PM
Stan added subscribers: nani, Stan.
Stan added inline comments.
/ps/trunk/binaries/data/mods/public/gui/gamesetup/Controllers/LobbyGameRegistration.js
129
In D3719, @nani wrote:

Now this doesn't do anything (some how it did in alpha 24). The else branch never gets called and no data about what team is the player in or if if the players is observer is stored. This results in sending nonsense to the lobby game list (players column being 10/8 but no observers, etc)

This commit now has outstanding concerns.Aug 9 2021, 4:52 PM
Stan resigned from this commit.Sep 10 2021, 8:47 AM

Fixed in rP25851

This commit no longer requires audit.Sep 10 2021, 8:47 AM