Diffusion 0 A.D. Public Repository rP25151

Refuse to serialize NaN values.
rP25151
Actions

Description

Refuse to serialize NaN values.

NaN values could not be serialised safely because of the multiple possible NaN numbers.
Since NaN values are usually the result of bugs or dangerous code, it seems simpler to refuse to serialise them.

(D3205 was a safe-serialization alternative, should the need arise).

Fixes #1879

Differential Revision: https://code.wildfiregames.com/D3729

Details

Committed

wraitii

Mar 28 2021, 6:48 PM

Differential Revision

D3729: Refuse to serialize NaN values.

Parents

rP25150: Fix degenerate case in UnitMotion resulting in lag.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 16471
Build 37204: Trigger Windows Autobuild
Build 37203: Post-Commit Build	Jenkins
Build 37202: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25151: Refuse to serialize NaN values..Mar 28 2021, 6:48 PM

wraitii added an edge: D3729: Refuse to serialize NaN values..

wraitii mentioned this in D3205: Reliably serialize NaN values..Mar 28 2021, 6:48 PM

Harbormaster completed building B16471: rP25151: Refuse to serialize NaN values..Mar 28 2021, 7:02 PM

I noticed a problem #6200

This commit now has outstanding concerns.Jun 3 2021, 7:07 AM

Freagarach mentioned this in rP25804: Fix serialisation crash when patrolling..Jun 17 2021, 9:40 AM

Langbart resigned from this commit.Jun 17 2021, 2:33 PM

This commit no longer requires audit.Jun 17 2021, 2:33 PM

I just had a discussion with @elexis, it would be good if we can't crash from JS (might have been a thing in the past). So it would be nice if we could reliably serialise NaN and error, or just don't serialise but do error.

Silier removed an auditor: Langbart.Jun 21 2021, 9:07 PM