Replaces CPos by more a consistent CVector2D, reduces geometry code duplication.
Tested By: Freagarach, Langbart
Differential Revision: https://code.wildfiregames.com/D3759
Description
Description
Details
Details
- Committed
vladislavbelov Mar 28 2021, 11:55 PM - Differential Revision
- D3759: Replaces CPos by more consistent CVector2D
- Parents
- rP25151: Refuse to serialize NaN values.
- Branches
- Unknown
- Tags
- Build Status
Buildable 16472 Build 37207: Trigger Windows Autobuild Build 37206: Post-Commit Build Jenkins Build 37205: Post-Commit Build (macOS) Jenkins
Event Timeline
| /ps/trunk/binaries/data/mods/public/gui/summary/summary.js | ||
|---|---|---|
| 353 | Why not Vector2D? here as well? | |
| /ps/trunk/binaries/data/mods/public/gui/summary/summary.js | ||
|---|---|---|
| 353 | (Perhaps a nonexistent conversion interface?) | |
| /ps/trunk/binaries/data/mods/public/gui/summary/summary.js | ||
|---|---|---|
| 353 | On the C++ side we have CVector2D for graphics/ui and CFixedVector2D for simulation, on the JS side Vector2D is used everywhere. To use Vector2D here we need to have a strict design about conversions first. | |
| /ps/trunk/binaries/data/mods/public/gui/summary/summary.js | ||
|---|---|---|
| 353 | One might use Vector2D here and it will work, but it'll be a coincidence that it requires the same fields. | |