HomeWildfire Games

Allow empty actor files.
AuditedrP25224

Description

Allow empty actor files.

This allows empty actor files -> they map to a dummy object that renders nothing.
The use case is automatically hiding objects at lower quality levels & LOD settings.

Differential Revision: https://code.wildfiregames.com/D3819

Event Timeline

Stan added a subscriber: Stan.Apr 9 2021, 6:27 PM

Should we create a thread to make use of that feature? I'm thinking greaves, aprons arrows in quivers (maybe arrows completely) possibly some other stuff?

In rP25224#50589, @Stan wrote:

Should we create a thread to make use of that feature? I'm thinking greaves, aprons arrows in quivers (maybe arrows completely) possibly some other stuff?

Yes, that sounds like a plan to me. We also can ask people for lower quality models for some things perhaps (dunno if we have much that's relevant).
IMO decoration props also should be looked at.

Stan added a comment.Apr 9 2021, 6:31 PM

Ideally all props should be like that blacksmith's but we need instancing ?

In rP25224#50591, @Stan wrote:

Ideally all props should be like that blacksmith's but we need instancing ?

Well ideally yes, but in the meantime we can still update them anyways :)

Stan raised a concern with this commit.Apr 11 2021, 1:20 PM
Stan added a subscriber: Langbart.

Apparently (According to @Langbart it broke fields)

This commit now has outstanding concerns.Apr 11 2021, 1:20 PM
In rP25224#50622, @Stan wrote:

Apparently (According to @Langbart it broke fields)

Yes, I can not see this specific field after rP25224. "Units Demo" scenario map, it is in the lower left corner when you spawn into the game.

Stan added a comment.Apr 11 2021, 3:42 PM

What field is this ? Open it in atlas. )

Langbart added a comment.EditedApr 11 2021, 4:22 PM
In rP25224#50631, @Stan wrote:

What field is this ? Open it in atlas. )

I get nothing for generic_field and rubble_field


Stan added a comment.Apr 11 2021, 4:29 PM

Actually it's even worse, it broke every single decal in the game. The field doesn't work, cause it's decal only.

Stan added inline comments.Apr 11 2021, 6:56 PM
/ps/trunk/source/graphics/ObjectEntry.cpp
81

This check is wrong. you need && (variation.decal.m_SizeX != 0 || variation.decal.m_SizeZ != 0) or something like that.

wraitii added inline comments.Apr 11 2021, 7:48 PM
/ps/trunk/source/graphics/ObjectEntry.cpp
81

Mh, I actually just put this too high, it should be below the two ifs under.

Pretty sure I thought of this too, just didn't take care to follow through.

wraitii requested verification of this commit.Apr 11 2021, 9:05 PM
This commit now requires verification by auditors.Apr 11 2021, 9:05 PM
Stan accepted this commit.Apr 12 2021, 11:10 AM
All concerns with this commit have now been addressed.Apr 12 2021, 11:10 AM