HomeWildfire Games
Diffusion 0 A.D. Public Repository rP25312

Make player entities more visible on minimap
rP25312
Actions

Description

Make player entities more visible on minimap

This patch is increasing contrast of player colours used on minimap in minimap component instead of changing player colours themselves to not mess with other cases, when they are used.

Differential revision: D3242
Comments by: @vladislavbelov, @ValihrAnt, @Freagarach

Details

Auditors
Langbart
Committed
SilierApr 25 2021, 1:05 PM
Differential Revision
D3242: [Proposal] Make player entities more visible on minimap
Parents
rP25311: Use better colour in multiplayer lobby for away status
Branches
Unknown
Tags
Unknown
Reverted By
rP25313: Revert rP25312
Build Status
Buildable 16896
Build 38639: Trigger Windows Autobuild
Build 38638: Post-Commit BuildJenkins
Build 38637: Post-Commit Build (macOS)Jenkins

Event Timeline

Silier committed rP25312: Make player entities more visible on minimap.Apr 25 2021, 1:05 PM
Silier added an edge: D3242: [Proposal] Make player entities more visible on minimap.
Silier added subscribers: ValihrAnt, Freagarach, vladislavbelov.
Harbormaster completed building B16896: rP25312: Make player entities more visible on minimap.Apr 25 2021, 1:20 PM
Langbart raised a concern with this commit.Apr 25 2021, 1:23 PM
Langbart added a subscriber: Langbart.

The orange player entities are displayed in red dots.

This commit now has outstanding concerns.Apr 25 2021, 1:23 PM
Stan added a subscriber: Stan.Apr 25 2021, 1:26 PM

No they are not ? I see orange dots and red ones

Silier mentioned this in D3890: Lower contrast for player colour on minimap.Apr 25 2021, 1:48 PM

thank you
https://code.wildfiregames.com/D3890

Silier added a reverting change: rP25313: Revert rP25312.Apr 25 2021, 3:43 PM
Silier requested verification of this commit.Apr 25 2021, 3:43 PM
This commit now requires verification by auditors.Apr 25 2021, 3:43 PM
Langbart resigned from this commit.Apr 25 2021, 4:02 PM
This commit no longer requires audit.Apr 25 2021, 4:02 PM

Changes (3)

PathSize
ps/
trunk/
source/
gui/
ObjectTypes/
simulation2/
components/

rP25312

View Options

ps/trunk/source/gui/ObjectTypes/CMiniMap.cpp

Loading...
View Options

ps/trunk/source/simulation2/components/CCmpMinimap.cpp

Loading...
View Options

ps/trunk/source/simulation2/components/ICmpMinimap.h

Loading...
Wildfire Games ยท Phabricator