Diffusion 0 A.D. Public Repository rP25465

Require 'Resistance' in CanAttack
AuditedrP25465
Actions

Description

Require 'Resistance' in CanAttack

This was already effectively the case, so this change increases coherence.

Accepted By: Freagarach

Differential Revision: https://code.wildfiregames.com/D3980

Details

Auditors

Freagarach

Committed

wraitii

May 19 2021, 2:36 PM

Differential Revision

D3980: Require 'Resistance' in CanAttack

Parents

rP25464: Differentiate movement speeds of ranged cavalry

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17326
Build 40011: Post-Commit Build	Jenkins
Build 40010: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25465: Require 'Resistance' in CanAttack.May 19 2021, 2:36 PM

wraitii added an edge: D3980: Require 'Resistance' in CanAttack.

Harbormaster completed building B17326: rP25465: Require 'Resistance' in CanAttack.May 19 2021, 2:55 PM

Freagarach raised a concern with this commit.May 22 2021, 8:53 AM

Freagarach added a subscriber: Freagarach.

Freagarach added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js
234	Mirages don't mock resistance, so we can't attack mirages anymore.

This commit now has outstanding concerns.May 22 2021, 8:53 AM

wraitii mentioned this in D4001: Fix CanAttack for mirages following rP25465.May 22 2021, 10:18 AM

wraitii mentioned this in rP25517: Fix CanAttack for mirages following rP25465.May 22 2021, 12:57 PM

@Freagarach is it fixed?

My concern was fixed in rP25517.
(Sorry for the delay.)

All concerns with this commit have now been addressed.Jun 1 2021, 8:48 AM

bb mentioned this in rP25368: Let entity react on target death directly..Sep 5 2021, 11:30 PM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Attack.js

tests/

test_Attack.js

rP25465

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Attack.js