Diffusion 0 A.D. Public Repository rP25546

Mod data parsing rework
rP25546
Actions

Description

Mod data parsing rework

Parses mod.json data not only in temporary JS values, but in a proper C++ struct.
This will ultimately make it more convenient to pass more than just the version to JS in D3968, and it enforces the schema a bit more.

Differential Revision: https://code.wildfiregames.com/D3988

Details

Committed

wraitii

May 25 2021, 8:12 AM

Differential Revision

D3988: Mod data parsing rework

Parents

rP25545: Prevent hotkeys from firing for disabled buttons

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17500
Build 40552: Trigger Windows Autobuild
Build 40551: Post-Commit Build	Jenkins
Build 40549: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25546: Mod data parsing rework.May 25 2021, 8:12 AM

wraitii added an edge: D3988: Mod data parsing rework.

Harbormaster completed building B17500: rP25546: Mod data parsing rework.May 25 2021, 8:56 AM

wraitii mentioned this in rP25548: Fix rP25546 - re-add special-casing of mod & user mods.May 25 2021, 9:50 AM

wraitii mentioned this in rP25579: Fix GetLoadedModsWIthVersions following r25546.May 27 2021, 10:30 AM

This broke showing installed pyromod in available mods until next start

This commit now has outstanding concerns.Aug 9 2021, 8:47 PM

Think I failed to notice that because that's always been broken on mac OS :/

Silier added inline comments.Aug 10 2021, 5:48 PM

/ps/trunk/source/ps/Mod.cpp
202	I am a bit puzzled, what does this make here? This is called everytime on Enabling mods, where is m_Availablemods cleared then? Should not this be elsewhere?