HomeWildfire Games

Allow mods to say they should be ignored in replay/MP compatibility checks
Concern RaisedrP25634

Description

Allow mods to say they should be ignored in replay/MP compatibility checks

Since it is very non-trivial to determine which mods change checksums and which don't, this relies on modder goodwill (and on verification on our end for signed mods).

The declaration is an optional "ignoreInCompatibilityChecks" boolean in mod.json

Also rework slightly the MP lobby mod display to always show the host mods in a clear manner.

Differential Revision: https://code.wildfiregames.com/D3968

Event Timeline

Angen added a subscriber: Angen.Jun 2 2021, 8:29 PM
Angen added inline comments.
/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
7

ERROR: JavaScript error: gui/common/mod.js line 9 Script value conversion check failed: v.isString() || v.isNumber() || v.isBoolean() (got type undefined) hasSameMods@gui/common/mod.js:9:16 loadFile@gui/gamesetup/Persistence/PersistentMatchSettings.js:28:4 onLoad@gui/gamesetup/Controllers/GameSettingsController.js:87:76 SetupWindow@gui/gamesetup/SetupWindow.js:59:11 init@gui/gamesetup/gamesetup.js:47:18 onPress@gui/pregame/MainMenuItems.js:90:13 performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9 pressButton@gui/pregame/MainMenuItemHandler.js:63:10

ERROR: GUI page 'page_gamesetup.xml': Failed to call init() function

It is solved by deleting matchsettings from config but it will cause a lot of reports in release

Angen added inline comments.Jun 2 2021, 8:32 PM
/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
7
wraitii added inline comments.Jun 2 2021, 9:47 PM
/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
7

mh, bit confused, as I do check for undefined at L7 and the error pops up L9.
I guess I must be missing something.

Langbart raised a concern with this commit.Sun, Jul 11, 3:35 PM
Langbart added a subscriber: Langbart.

I have investigated the problem for ticket #6201 and I think it starts with this changeset version.

This commit now has outstanding concerns.Sun, Jul 11, 3:35 PM
Angen raised a concern with this commit.Wed, Jul 21, 7:52 PM
Angen added inline comments.
/ps/trunk/binaries/data/mods/mod/gui/common/mod.js
21

this is supposed to use pathname, also old mods in replays stored as arrays will show undefined here