HomeWildfire Games

RM generation: improve metal mines generation
AuditedrP25772

Description

RM generation: improve metal mines generation

Introduces a new helper to place mines. use it on 'Best for MP' maps for stone and metal.

The amount of metal will scale with the # of players, and will place slightly more mines overall for fairer distribution.

This should make 1v1 and 4v4 more playable on these maps.

Differential Revision: https://code.wildfiregames.com/D4148

Event Timeline

Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/maps/random/rmgen-common/gaia_entities.js
128

Not sure the text reflects the committed situation?

wraitii added inline comments.Jun 16 2021, 5:12 PM
/ps/trunk/binaries/data/mods/public/maps/random/rmgen-common/gaia_entities.js
128

mh, you're right, that should apply to the sub-helpers now

Freagarach added inline comments.Jun 16 2021, 5:15 PM
/ps/trunk/binaries/data/mods/public/maps/random/rmgen-common/gaia_entities.js
132

By the way, it was this default value that hurts.

Freagarach raised a concern with this commit.Jun 16 2021, 5:44 PM

As stated inline.

This commit now has outstanding concerns.Jun 16 2021, 5:44 PM
Freagarach accepted this commit.Jun 29 2021, 8:59 AM

My concern is fixed in rP25811.

All concerns with this commit have now been addressed.Jun 29 2021, 8:59 AM
Langbart raised a concern with this commit.Aug 28 2021, 11:09 AM
Langbart added a subscriber: Langbart.

Is this a problem or intentional behavior?
Ticket: #6298

This commit now has outstanding concerns.Aug 28 2021, 11:09 AM
marder added a subscriber: marder.Feb 22 2022, 7:40 AM

the fix is included in D4086

should I just make a split diff to fix this?

Langbart resigned from this commit.Mar 7 2022, 11:13 AM
All concerns with this commit have now been addressed.Mar 7 2022, 11:13 AM