HomeWildfire Games
Diffusion 0 A.D. Public Repository rP25832

Fix foundation and corpses phenotypes being different than the source entity.
Concern RaisedrP25832
Actions

Description

Fix foundation and corpses phenotypes being different than the source entity.
Reported by: @wowgetoffyourcellphone

Details

Auditors
Freagarach
Committed
StanJul 21 2021, 12:04 AM
Parents
rP25831: Fix actor being different after foundation has been built.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18108
Build 42391: Post-Commit BuildJenkins
Build 42390: Post-Commit Build (macOS)Jenkins

Event Timeline

Stan committed rP25832: Fix foundation and corpses phenotypes being different than the source entity..Jul 21 2021, 12:04 AM
Stan added a subscriber: wowgetoffyourcellphone.
Harbormaster completed building B18108: rP25832: Fix foundation and corpses phenotypes being different than the source entity..Jul 21 2021, 12:18 AM
Freagarach added a subscriber: Freagarach.Jan 24 2023, 8:11 AM
Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/Foundation.js
354

(Always false.)

Stan added inline comments.Jan 24 2023, 8:16 AM
/ps/trunk/binaries/data/mods/public/simulation/components/Foundation.js
354

Oups.

Freagarach raised a concern with this commit.Jan 24 2023, 12:11 PM
Freagarach added a subscriber: elexis.
Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/Foundation.js
354

As pointed out by @elexis it throws an error for not being defined.

This commit now has outstanding concerns.Jan 24 2023, 12:11 PM
Freagarach mentioned this in D4909: Fix typo in foundation code..Jan 24 2023, 12:37 PM
Freagarach mentioned this in rP27508: Fix typo in foundation code..Jan 30 2023, 12:09 PM

Changes (3)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/

rP25832

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Foundation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/Health.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/Identity.js

Loading...
Wildfire Games ยท Phabricator