Allow to enable Cartography at the start of a match.
rP25869
Actions

Description

Allow to enable Cartography at the start of a match.

Adds a checkbox to the game setup to allow players to have Cartography autoresearched from the start of the match.
Refs. https://wildfiregames.com/forum/topic/27265-theres-any-mod-so-you-can-see-what-your-allies-see-from-the-start.

Patch by: @Jammyjamjamman
Differential revision: https://code.wildfiregames.com/D4191
Reviewed by: @Angen
Comments by: @andy5995, @Langbart

Details

Auditors

Langbart

Committed

Freagarach

Aug 28 2021, 8:15 AM

Reviewer

Silier

Differential Revision

D4191: Enable Cartography at Start of Game Option

Parents

rP25868: Implement "Call to the Arms"-button.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 18256
Build 42874: Trigger Windows Autobuild
Build 42873: Post-Commit Build	Jenkins
Build 42872: Post-Commit Build (macOS)	Jenkins

Event Timeline

Freagarach committed rP25869: Allow to enable Cartography at the start of a match..Aug 28 2021, 8:15 AM

Freagarach added an edge: D4191: Enable Cartography at Start of Game Option.

Freagarach added subscribers: Jammyjamjamman, Langbart, andy5995, Silier.

Harbormaster completed building B18256: rP25869: Allow to enable Cartography at the start of a match..Aug 28 2021, 8:30 AM

@Freagarach did you check changes done after initial review?

Aye. :) They looked exactly the same as the other options. ^^

Will this setting mean there is a useless tech ingame?

In rP25869#53659, @bb wrote:

Will this setting mean there is a useless tech ingame?

No, "Cartography" cannot be researched if the "Allied View" option was enabled. If it was not, you can research Cartography.

Fixes #5642.

An issue has been discovered that can be observed for the first time with this changeset. See #6356

This commit now has outstanding concerns.Oct 11 2021, 4:30 PM

In rP25869#54153, @Langbart wrote:

An issue has been discovered that can be observed for the first time with this changeset. See #6356

This can be fixed in MapExploration.js, by swapping L31 and L32. I can push a fix soon. Should this be done in a new patch?

In rP25869#54158, @Jammyjamjamman wrote:

I can push a fix soon. Should this be done in a new patch?

Yes, please. Link the trac ticket with it. will test tomorrow.

Jammyjamjamman mentioned this in D4305: Fix bug where scenario map was not loading as revealed when set to revealed..Oct 13 2021, 12:05 AM

I found some strange behavior that could be caused by this changeset, but I'm not sure, could you take a look at it? #6365

In rP25869#54228, @Langbart wrote:

I found some strange behavior that could be caused by this changeset, but I'm not sure, could you take a look at it? #6365

This bug is same fog of war bug. The other units aren't missing, just hidden. (You will see them if you send your units to attack.)

PS: I tested Phab:D4305 as there was another error related to [25869] (#6356), but it did not fix the problem.

When I applied D4305, It did fix that bug. However, 0AD does some strange caching + retrieval when loading previous scenario maps played. So if you initially played the map with 0ad svn on or after this commit, then apply D4305 and reload this game again, it will load the map with the same (buggy) settings as used on the game before this patch.

Long story short, apply D4305, start the game, select a different map, then select the Combat Demo (Huge) again and the map should load correctly.

In rP25869#54232, @Jammyjamjamman wrote:

In rP25869#54228, @Langbart wrote:

I found some strange behavior that could be caused by this changeset, but I'm not sure, could you take a look at it? #6365

This bug is same fog of war bug. The other units aren't missing, just hidden. (You will see them if you send your units to attack.)

PS: I tested Phab:D4305 as there was another error related to [25869] (#6356), but it did not fix the problem.

When I applied D4305, It did fix that bug. However, 0AD does some strange caching + retrieval when loading previous scenario maps played. So if you initially played the map with 0ad svn on or after this commit, then apply D4305 and reload this game again, it will load the map with the same (buggy) settings as used on the game before this patch.

Long story short, apply D4305, start the game, select a different map, then select the Combat Demo (Huge) again and the map should load correctly.