HomeWildfire Games

[PetraAI] - Manage bases in a separate BasesManager.

Description

[PetraAI] - Manage bases in a separate BasesManager.

The HQ should only care about high-level stuff, hence something like managing/looping individual bases is now done in a BasesManager, similar to the AttackManager.

Differential revision: https://code.wildfiregames.com/D4192
Comments by: @Angen
Fixes: #6185

Event Timeline

@Freagarach start we are legion with petra

Langbart raised a concern with this commit.Nov 12 2021, 3:18 PM
Langbart added a subscriber: Langbart.

A strong change in behavior could be observed with this set of changes - see #6381.

This commit now has outstanding concerns.Nov 12 2021, 3:18 PM
marder added a subscriber: marder.Nov 22 2021, 11:58 AM
Silier added inline comments.Dec 26 2021, 10:38 AM
/ps/trunk/binaries/data/mods/public/simulation/ai/petra/headquarters.js
2330

"baseManager"

/ps/trunk/binaries/data/mods/public/simulation/ai/petra/worker.js
690

question, wasnt here also baseless base counted since it was at index 0 ?

Freagarach marked 2 inline comments as done.Dec 28 2021, 7:13 AM
Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/ai/petra/worker.js
690

Nope, since its accessIndex always differs.

Langbart resigned from this commit.Jan 5 2022, 11:56 AM

The problem was fixed with the changeet rP26132.

This commit no longer requires audit.Jan 5 2022, 11:56 AM