HomeWildfire Games

Fixes an email that should be deleted by the i18n script but isn't because of…

Description

Fixes an email that should be deleted by the i18n script but isn't because of checkdiff.py
Fixes: https://github.com/0ad/0ad/pull/38
Patch by: @pappasadrian

Event Timeline

bb added a subscriber: bb.Sep 6 2021, 11:13 PM

Why do we distribute the addresses in the first place? Considering GDPR there is no legal basis whatsoever for that nor I see any interest in it since if one wants to get in touch with the translator one is much more likely to look at transifex instead of this file deep into some repo.. We should remove them somehow. Is there some transifex admin setting to disable that user setting? Otherwise we have to do it manually in the pullTranslations script.

because of checkdiff.py

I presume you mean that lines starting with # are excluded from the diff. Does that also mean that if just the translators change, the list doesn't get updated? If so that is obviously wrong. Maybe we should check for the first two characters being "#:" instead in that script.

Stan added a comment.Sep 7 2021, 9:19 AM

Given that each user has to do it manually in their user settings and I can't find anything related to that I suppose we'll have to do it manually.

Could probably reuse https://trac.wildfiregames.com/browser/ps/trunk/source/tools/i18n/creditTranslators.py#L132 which strips them.

(Could have used a named group for readability)

Note also that some names are duplicated and we might want to handle that.

wraitii added a subscriber: wraitii.Sep 7 2021, 9:30 AM

If you've failed to find a system-wide setting, I think we just need to strip the email manually. To be honest, I'm wondering how relevant it is to bundle the translator names at all in the .po files, but the email is definitely a larger issue.

I presume you mean that lines starting with # are excluded from the diff. Does that also mean that if just the translators change, the list doesn't get updated? If so that is obviously wrong.

It's slightly different: the script attempts to check for 'relevant' changes, i.e. changes to translations that are meaningful to stage & commit.
However, the logic is _extremely_ simple because it's fast and I was lazy when rewriting it. Possibly it could be changed to what you suggest. I'm not sure that the translators can really change without a meaningful translation change, though.

Stan added a comment.Sep 7 2021, 9:37 AM

We actually need the translator's names to be able to update the credits.

In rP25896#53803, @Stan wrote:

We actually need the translator's names to be able to update the credits.

We could pull them only when we update the credits to be honest, and not store them in the .po.

Stan added a comment.Sep 7 2021, 9:52 AM

Well it would be a mess because we'd then get extra translations changes after TF we'd have to get rid of.

bb added a comment.Sep 7 2021, 3:18 PM

Leaving the translator nick is, shouldn't be a problem. We handle them (considering GDPR) the same as any other contributing (not sure if we have the required PP written out, but whatever, we claim legitimate interest do we?). Keeping the year of contributions isn't a problem AFAIK.

I would be mostly in favour of having a admin setting (or pulling option in the transifex client) on the transifex side. If it doesn't exists maybe make a request at transifex for it? I guess considering the GDPR involvement it might be an option useful for other projects too.

Stan added a comment.Sep 7 2021, 4:03 PM

Sent them an e-mail

Hi there,

I work for the open source project 0 A.D. https://www.transifex.com/wildfire-games/0ad/dashboard/

Because of the GDPR legislation it would be better for us if we didn't get any emails at all in translation po files (here is an example https://github.com/0ad/0ad/blob/master/binaries/data/mods/public/l10n/fr.public-gui-manual.po) and is here an example of request to take it down, https://github.com/0ad/0ad/pull/38), when pulling them to transifex. Requiring all users to untick their email in their profile options is not really an option for us as we have some very old contributors which might not have been active in years.

We were not able to find any option to do it project wide. And we'd rather not have to parse the files to remove them.

Any help would be welcome

Regards,

Stanislas DOLCINI
Stan added a comment.Sep 8 2021, 3:07 PM

Answer:

Hello Stanislas,

Thank you for reaching out to Transifex support. I apologize for the inconvenience.
Regarding our notifications, This notifications are configured by user and not by project, unfortunately we don't have away to disable notifications in BULK so every user must disable their own notifications.

If you have any further questions please let me know
Best Regards
Cesar

My reply:

Hi Cesar

Unfortunately, that does not answer my question :)

My question is about https://www.transifex.com/user/settings/ And specifically the "Show my address in translation files" We wish to disable it for the whole project so users do not have to. Because it's a GDPR issue to have it in translation files and we do not need it at all.

Best regards,

Final answer (That's a no):

Hollo Stanislas,

I apologize for the misunderstanding, Now with the explanation you just provided it is more clear to me, Thank you!.
Unfortunately we don't have away to disable the "Show my address in translation files" by project, each user must disable it and save the changes.

Best Regards
Cesar

Looks to me rather unlikely that'd we'd get them to move quickly on this? Maybe they have an issue tracker where you can report that.

IMO the simplest solution would be to regex-strip <[^@]@[^>]> from translator names via the Babel catalog, or via text editing, whichever is easier.

Stan added a comment.Sep 8 2021, 3:48 PM

I asked just in case but yeah looks like we will need to teach the script that pulls translations how to clean the files.