Diffusion 0 A.D. Public Repository rP25926

Fix duplicate insertion error when detecting incompatible mods.
rP25926
Actions

Description

Fix duplicate insertion error when detecting incompatible mods.

Since rP25410, mods are checked for compatibility. However, they can incorrectly be checked & added to inompatible mods several time, leading to a potential crash.

The new code can also be simplified slightly.

Reviewed By: Angen

Differential Revision: https://code.wildfiregames.com/D4276

Details

Committed

wraitii

Sep 17 2021, 6:59 PM

Reviewer

Silier

Differential Revision

D4276: Fix potential crash when parsing incompatible mods since rP25410

Parents

rP25925: Add tooltip to modmod explaining about loading order

Branches

Unknown

Tags

Unknown

Build Status

Buildable 18440
Build 43449: Trigger Windows Autobuild
Build 43448: Post-Commit Build	Jenkins
Build 43447: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25926: Fix duplicate insertion error when detecting incompatible mods..Sep 17 2021, 6:59 PM

wraitii added an edge: D4276: Fix potential crash when parsing incompatible mods since rP25410.

You mean after inserting erease code rP25634

Harbormaster completed building B18440: rP25926: Fix duplicate insertion error when detecting incompatible mods..Sep 17 2021, 9:47 PM

Changes (2)

Path

Size

ps/

trunk/

source/

ps/

Mod.cpp

tests/

test_Mod.h

rP25926

View Options

ps/trunk/source/ps/Mod.cpp