HomeWildfire Games

Add an extra button to skip the summary page when quitting.


Add an extra button to skip the summary page when quitting.

Allows devs (and players) to skip the summary page when they don't need them.

Patch by: @Schweini
Differential revision: https://code.wildfiregames.com/D3958
Reviewed by: @Langbart
Fixes: #4300
Comments by: @nwtour, @Stan

Event Timeline

bb raised a concern with this commit.EditedOct 31 2021, 6:13 PM
bb added a subscriber: bb.

I have absolutely no clue, what choice the game is asking me to make. I suspect this to come from here.

Happens when pressing exit as a MP client

This commit now has outstanding concerns.Oct 31 2021, 6:14 PM

This definitely shouldn't happen. I will look at it as soon as possible,.
This dialog pops up when finishing a game, right?

bb added a comment.Oct 31 2021, 6:25 PM

I just pressed exit in the menu during the game (not at the end) as a client (so non-host) in an MP game. Obviously one should test the case too what happens at the end of the game for clients.

I'm pretty sure I overlooked something then. I'll be at my main machine tomorrow I think, then I'll be able to provide a fix.

bb accepted this commit.Dec 25 2021, 3:15 PM

Seems fixed. Notice that when leaving a game without resigning, the option to go to the summary is not there, which is good.

All concerns with this commit have now been addressed.Dec 25 2021, 3:15 PM