HomeWildfire Games

Removes binding native GLuint textures from public ShaderProgram API.
AuditedrP26143

Description

Removes binding native GLuint textures from public ShaderProgram API.

Differential Revision: https://code.wildfiregames.com/D4407

Event Timeline

nwtour raised a concern with this commit.Jan 6 2022, 6:07 AM
nwtour added a subscriber: nwtour.

Look like part of this changes:
Open Developer panel in-game, click "Shadow frustrum" (build with make config=release)

GAME STARTED, ALL INIT COMPLETE

Thread 1 "main" received signal SIGSEGV, Segmentation fault.
0x0832e2fb in ShadowMap::RenderDebugTexture (this=0x8e6417c) at ../../../source/renderer/ShadowMap.cpp:790
790             g_Renderer.BindTexture(0, m->Texture->GetHandle());
(gdb) bt
#0  0x0832e2fb in ShadowMap::RenderDebugTexture (this=0x8e6417c) at ../../../source/renderer/ShadowMap.cpp:790
#1  0x08327655 in CSceneRenderer::RenderSubmissions (this=0x8e0b14c, waterScissor=...) at ../../../source/renderer/SceneRenderer.cpp:992
#2  0x0832864a in CSceneRenderer::RenderScene (this=0x8e0b14c, scene=...) at ../../../source/renderer/SceneRenderer.cpp:1248
#3  0x082bff85 in CGameView::Render (this=0x8f4e610) at ../../../source/graphics/GameView.cpp:246
#4  0x0831d14e in CRenderer::RenderFrameImpl (this=0x8e4d900, renderGUI=<optimized out>, renderLogger=<optimized out>) at ../../../source/renderer/Renderer.cpp:507
#5  0x0831d06f in CRenderer::RenderFrame (this=0x8e4d900, needsPresent=<optimized out>) at ../../../source/renderer/Renderer.cpp:479
#6  0x08073478 in Frame () at ../../../source/main.cpp:452
#7  RunGameOrAtlas (argc=argc@entry=1, argv=argv@entry=0xbffff7d4) at ../../../source/main.cpp:691
#8  0x0807064b in main (argc=1, argv=0xbffff7d4) at ../../../source/main.cpp:743
This commit now has outstanding concerns.Jan 6 2022, 6:07 AM
vladislavbelov requested verification of this commit.Jan 6 2022, 12:06 PM

Look like part of this changes:
Open Developer panel in-game, click "Shadow frustrum" (build with make config=release)

GAME STARTED, ALL INIT COMPLETE

Thread 1 "main" received signal SIGSEGV, Segmentation fault.
0x0832e2fb in ShadowMap::RenderDebugTexture (this=0x8e6417c) at ../../../source/renderer/ShadowMap.cpp:790
790             g_Renderer.BindTexture(0, m->Texture->GetHandle());
(gdb) bt
#0  0x0832e2fb in ShadowMap::RenderDebugTexture (this=0x8e6417c) at ../../../source/renderer/ShadowMap.cpp:790
#1  0x08327655 in CSceneRenderer::RenderSubmissions (this=0x8e0b14c, waterScissor=...) at ../../../source/renderer/SceneRenderer.cpp:992
#2  0x0832864a in CSceneRenderer::RenderScene (this=0x8e0b14c, scene=...) at ../../../source/renderer/SceneRenderer.cpp:1248
#3  0x082bff85 in CGameView::Render (this=0x8f4e610) at ../../../source/graphics/GameView.cpp:246
#4  0x0831d14e in CRenderer::RenderFrameImpl (this=0x8e4d900, renderGUI=<optimized out>, renderLogger=<optimized out>) at ../../../source/renderer/Renderer.cpp:507
#5  0x0831d06f in CRenderer::RenderFrame (this=0x8e4d900, needsPresent=<optimized out>) at ../../../source/renderer/Renderer.cpp:479
#6  0x08073478 in Frame () at ../../../source/main.cpp:452
#7  RunGameOrAtlas (argc=argc@entry=1, argv=argv@entry=0xbffff7d4) at ../../../source/main.cpp:691
#8  0x0807064b in main (argc=1, argv=0xbffff7d4) at ../../../source/main.cpp:743

Fixed in rP26173.

This commit now requires verification by auditors.Jan 6 2022, 12:06 PM
All concerns with this commit have now been addressed.Jan 6 2022, 12:37 PM