HomeWildfire Games

Performs texture uploads via DeviceCommandContext interface.
AuditedrP26170

Description

Performs texture uploads via DeviceCommandContext interface.

Tested By: Langbart, Stan

Differential Revision: https://code.wildfiregames.com/D4415

Event Timeline

nwtour raised a concern with this commit.Jan 6 2022, 1:07 PM
nwtour added a subscriber: nwtour.

Look like part of this change:
Developer panel -> Click on "Hier pathfinding". Crash : "dataSize == width * height * bpp"

In renderer/TerrainOverlay.cpp W=1280 H=1280
In renderer/backend/gl/DeviceCommandContext.cpp W=2048, H=2048

#6  0x084ba2f1 in debug_OnAssertionFailure (expr=0x857fbf8 L"dataSize == width * height * bpp", 
    suppress=0x86a635c <Renderer::Backend::GL::CDeviceCommandContext::UploadTextureRegion(Renderer::Backend::GL::CTexture*, Renderer::Backend::Format, void const*, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)::suppress__>, file=0x857fa88 L"../../../source/renderer/backend/gl/DeviceCommandContext.cpp", line=61, func=0x857fe94 "UploadTextureRegion")
    at ../../../source/lib/debug.cpp:547
#7  0x083682ec in Renderer::Backend::GL::CDeviceCommandContext::UploadTextureRegion (this=<optimized out>, texture=0x118409b0, format=Renderer::Backend::Format::R8G8B8A8, data=0x8f102010, 
    dataSize=6553600, xOffset=0, yOffset=0, width=2048, height=2048) at ../../../source/renderer/backend/gl/DeviceCommandContext.cpp:61
#8  0x083681ae in Renderer::Backend::GL::CDeviceCommandContext::UploadTexture (this=0x8eaac50, texture=0x118409b0, format=Renderer::Backend::Format::R8G8B8A8, data=0x8f102010, 
    dataSize=6553600) at ../../../source/renderer/backend/gl/DeviceCommandContext.cpp:48
#9  0x08340599 in TerrainTextureOverlay::RenderAfterWater (this=0xf1b0fd0, deviceCommandContext=0x8eaac50, cullGroup=0) at ../../../source/renderer/TerrainOverlay.cpp:342
#10 0x0833d7a8 in ITerrainOverlay::RenderOverlaysAfterWater (deviceCommandContext=0x8eaac50, cullGroup=0) at ../../../source/renderer/TerrainOverlay.cpp:86
#11 0x08326fdb in CSceneRenderer::RenderSubmissions (this=0x8e0c14c, deviceCommandContext=0x8eaac50, waterScissor=...) at ../../../source/renderer/SceneRenderer.cpp:960
#12 0x0832813e in CSceneRenderer::RenderScene (this=0x8e0c14c, deviceCommandContext=0x8eaac50, scene=...) at ../../../source/renderer/SceneRenderer.cpp:1252
#13 0x082bfe28 in CGameView::Render (this=0x98b1370) at ../../../source/graphics/GameView.cpp:246
#14 0x0831cb4e in CRenderer::RenderFrameImpl (this=0x8e4e280, renderGUI=<optimized out>, renderLogger=<optimized out>) at ../../../source/renderer/Renderer.cpp:515
#15 0x0831ca6f in CRenderer::RenderFrame (this=0x8e4e280, needsPresent=<optimized out>) at ../../../source/renderer/Renderer.cpp:487
#16 0x080734d8 in Frame () at ../../../source/main.cpp:452
#17 RunGameOrAtlas (argc=argc@entry=1, argv=argv@entry=0xbffff7d4) at ../../../source/main.cpp:691
#18 0x080706ab in main (argc=1, argv=0xbffff7d4) at ../../../source/main.cpp:743
This commit now has outstanding concerns.Jan 6 2022, 1:07 PM
vladislavbelov requested verification of this commit.Jan 6 2022, 3:17 PM

Fixed in rP26176.

This commit now requires verification by auditors.Jan 6 2022, 3:17 PM
All concerns with this commit have now been addressed.Jan 6 2022, 4:28 PM

bisecting leads me to this changeset for ticket #6524

Langbart raised a concern with this commit.May 2 2022, 1:22 PM
This commit now has outstanding concerns.May 2 2022, 1:22 PM
All concerns with this commit have now been addressed.Aug 6 2022, 7:10 PM