HomeWildfire Games
Diffusion 0 A.D. Public Repository rP26215

Splits water surface and shore drawing functions and fixes their switch.
AuditedrP26215
Actions

Description

Splits water surface and shore drawing functions and fixes their switch.

Differential Revision: https://code.wildfiregames.com/D4436

Details

Auditors
Freagarach
Committed
vladislavbelovJan 14 2022, 6:34 PM
Differential Revision
D4436: Splits water surface and shore drawing functions and fixes their switch
Parents
rP26214: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19170
Build 45702: Trigger Windows Autobuild
Build 45701: Post-Commit BuildJenkins
Build 45700: Post-Commit Build (macOS)Jenkins

Event Timeline

vladislavbelov committed rP26215: Splits water surface and shore drawing functions and fixes their switch..Jan 14 2022, 6:34 PM
vladislavbelov added an edge: D4436: Splits water surface and shore drawing functions and fixes their switch.
Harbormaster failed to build B19170: rP26215: Splits water surface and shore drawing functions and fixes their switch.!Jan 14 2022, 6:37 PM
Freagarach mentioned this in rP26217: Moves hardcoded blend state in ParticleRenderer to the transparent particles….Jan 15 2022, 8:39 AM
Freagarach raised a concern with this commit.
Freagarach added a subscriber: Freagarach.

See https://code.wildfiregames.com/rP26217#55333.

This commit now has outstanding concerns.Jan 15 2022, 8:39 AM
vladislavbelov mentioned this in rP26223: Removes binding additional attribute for water shader added in rP26215..Jan 15 2022, 5:47 PM
vladislavbelov requested verification of this commit.Jan 15 2022, 5:48 PM

Fixed in rP26223.

This commit now requires verification by auditors.Jan 15 2022, 5:48 PM
Freagarach accepted this commit.Jan 16 2022, 7:25 AM

My concern was fixed, I can play again. \o/

All concerns with this commit have now been addressed.Jan 16 2022, 7:25 AM
wraitii added a subscriber: wraitii.Jan 17 2022, 7:28 PM

I suppose this is the diff:


Only seems to happen with this combination of settings.

vladislavbelov added a comment.Jan 17 2022, 7:39 PM
In rP26215#55398, @wraitii wrote:

Only seems to happen with this combination of settings.

Thanks! I found, WillRenderFancyWater checks for PrettyWater but to draw shores we need WaterFancyEffects.

vladislavbelov mentioned this in rP26231: Fixes fancy water shores drawing after rP26215..Jan 20 2022, 6:32 PM
vladislavbelov added a comment.Jan 20 2022, 6:33 PM
In rP26215#55398, @wraitii wrote:

Only seems to happen with this combination of settings.

Fixed in rP26231.

Changes (4)

PathSize
ps/
trunk/
source/
renderer/

rP26215

View Options

ps/trunk/source/renderer/PatchRData.cpp

Loading...
View Options

ps/trunk/source/renderer/PatchRData.h

Loading...
View Options

ps/trunk/source/renderer/TerrainRenderer.cpp

Loading...
View Options

ps/trunk/source/renderer/WaterManager.h

Loading...
Wildfire Games · Phabricator