HomeWildfire Games
Diffusion 0 A.D. Public Repository rP26458

Make Icon non-optional.
AuditedrP26458
Actions

Description

Make Icon non-optional.

Requested by @bb in D4476.
Differential revision: https://code.wildfiregames.com/D4484
Reviewed by: @bb

Details

Auditors
Stan
Committed
FreagarachFeb 21 2022, 8:20 AM
Reviewer
bb
Differential Revision
D4484: Make Icon non-optional.
Parents
rP26457: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19592
Build 46868: Post-Commit BuildJenkins
Build 46867: Post-Commit Build (macOS)Jenkins

Event Timeline

Freagarach committed rP26458: Make Icon non-optional..Feb 21 2022, 8:20 AM
Freagarach added an edge: D4484: Make Icon non-optional..
Freagarach added a subscriber: bb.
Harbormaster completed building B19592: rP26458: Make Icon non-optional..Feb 21 2022, 8:38 AM
Stan raised a concern with this commit.Feb 22 2022, 10:16 PM
Stan added a subscriber: Stan.
ERROR: RelaxNGValidator: Validation error: special/spy:1: Expecting an element Icon, got nothing

ERROR: RelaxNGValidator: Validation error: special/spy:1: Invalid sequence in interleave

ERROR: RelaxNGValidator: Validation error: special/spy:1: Element Identity failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'special/spy'

ERROR: Errors executing script event "Press"

ERROR: JavaScript error: gui/session/session.js line 225 deepfreeze requires exactly one object as an argument. GetTemplateData@gui/session/session.js:225:34 update@gui/session/diplomacy/playercontrols/SpyRequestButton.js:52:33 update@gui/session/diplomacy/DiplomacyPlayerControl.js:36:35 updatePanels@gui/session/diplomacy/DiplomacyDialog.js:49:44 open@gui/session/diplomacy/DiplomacyDialog.js:59:8 toggle@gui/session/diplomacy/DiplomacyDialog.js:80:9
This commit now has outstanding concerns.Feb 22 2022, 10:16 PM
wowgetoffyourcellphone added a subscriber: wowgetoffyourcellphone.Feb 22 2022, 10:27 PM

Add this to the special/spy template?

<Icon>technologies/spy_trader.png</Icon>
Freagarach mentioned this in D4503: Give an icon to the spy..Feb 23 2022, 4:38 PM
Freagarach mentioned this in rP26478: Give an icon to the spy..Feb 25 2022, 6:59 AM
Stan accepted this commit.Mar 4 2022, 4:30 PM
All concerns with this commit have now been addressed.Mar 4 2022, 4:30 PM

Changes (25)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/
templates/
skirmish/
units/
special/
players/
template_player.xml/
special/
player.xml

rP26458

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Identity.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/skirmish/units/default_cavalry.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/skirmish/units/default_infantry_melee_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/skirmish/units/default_infantry_ranged_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/skirmish/units/default_ship_trireme.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/skirmish/units/default_siege_ram.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/skirmish/units/default_support_female_citizen.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/skirmish/units/special_starting_unit.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/player.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/athen.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/brit.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/cart.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/gaia.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/gaul.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/han.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/iber.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/kush.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/mace.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/maur.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/pers.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/ptol.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/rome.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/sele.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/players/spart.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_player.xml

Loading...
Wildfire Games ยท Phabricator