Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP26815

Moves vertex attribute binding to CDeviceCommandContext.
rP26815
Actions

Tags

None

Subscribers

Description

Moves vertex attribute binding to CDeviceCommandContext.

Patch By: Langbart, Stan

Differential Revision: https://code.wildfiregames.com/D4610

Details

Auditors

Committed

Apr 23 2022, 10:11 PM

Differential Revision

D4610: Moves vertex attribute binding to CDeviceCommandContext

Parents

rP26814: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 20169
Build 48453: Trigger Windows Autobuild
Build 48452: Post-Commit Build	Jenkins
Build 48451: Post-Commit Build (macOS)	Jenkins

Event Timeline

vladislavbelov committed rP26815: Moves vertex attribute binding to CDeviceCommandContext..Apr 23 2022, 10:11 PM

vladislavbelov added an edge: D4610: Moves vertex attribute binding to CDeviceCommandContext.

Patch By > Tested By.

Harbormaster completed building B20169: rP26815: Moves vertex attribute binding to CDeviceCommandContext..Apr 23 2022, 10:48 PM

Some issues with particles were noted, wowgetoffmang mentioned that you can`t see the smoke on the Han forge and I have strange looking fires when buildings are destroyed.
#6519

This commit now has outstanding concerns.Apr 26 2022, 7:03 AM

vladislavbelov requested verification of this commit.Apr 26 2022, 8:13 PM

This commit now requires verification by auditors.Apr 26 2022, 8:13 PM

vladislavbelov mentioned this in rP26829: Fixes incorrect vertex buffer offset added in rP26815. Fixes #6519.Apr 26 2022, 8:14 PM

Thank you for quickly fixing the problem in the ticket with rP26829.

This commit no longer requires audit.Apr 26 2022, 8:30 PM

Ended up at this commit after bisecting.
#6520

Langbart raised a concern with this commit.Apr 27 2022, 1:29 PM

This commit now has outstanding concerns.Apr 27 2022, 1:29 PM

vladislavbelov mentioned this in rP26833: Adds backend buffer upload forgotten in rP26815. Fixes #6520.Apr 27 2022, 9:00 PM

In rP26815#57582, @Langbart wrote:

Ended up at this commit after bisecting.
#6520

Fixed in rP26833.

This commit now requires verification by auditors.Apr 27 2022, 9:01 PM

In rP26815#57590, @vladislavbelov wrote:

Fixed in rP26833.

Ok.

All concerns with this commit have now been addressed.Apr 27 2022, 10:08 PM

The mentioned performance difference between OpenGL and OpenGL ARB in D4631 is caused by this changeset. See ticket #6525 for more details.

This commit now has outstanding concerns.May 2 2022, 2:47 PM

This commit no longer requires audit.May 3 2022, 9:24 AM

Freagarach added a subscriber: Freagarach.Jun 10 2022, 7:26 AM

Freagarach added inline comments.

/ps/trunk/source/ps/Profiler2GPU.h

Profiler2GPU.cpp
In file included from ../../../source/ps/Profiler2GPU.cpp:25:
../../../source/ps/Profiler2GPU.h:45:6: warning: "CONFIG2_GLES" is not defined, evaluates to 0 [-Wundef]
   45 | #if !CONFIG2_GLES
      |      ^~~~~~~~~~~~

Stan mentioned this in P279 Find missing macro/symbol headers.Jun 22 2022, 3:11 PM

Changes (37)

Path

Size

ps/

trunk/

source/

graphics/

MiniMapTexture.cpp

ParticleEmitter.cpp

ShaderProgram.h

TextRenderer.cpp

gui/

ObjectTypes/

ps/

Profiler2GPU.cpp

renderer/

DebugRenderer.cpp

HWLightingModelRenderer.cpp

HWLightingModelRenderer.h

InstancingModelRenderer.cpp

InstancingModelRenderer.h

ModelRenderer.cpp

ModelVertexRenderer.h

OverlayRenderer.cpp

ParticleRenderer.cpp

PostprocManager.cpp

SilhouetteRenderer.cpp

TerrainOverlay.cpp

TerrainRenderer.cpp

TexturedLineRData.cpp

VertexArray.cpp

VertexBuffer.cpp

WaterManager.cpp

backend/

IShaderProgram.h

gl/

DeviceCommandContext.cpp

DeviceCommandContext.h

ShaderProgram.cpp

ShaderProgram.h

rP26815

ps/trunk/source/graphics/Canvas2D.cpp

Loading...

ps/trunk/source/graphics/LOSTexture.cpp

Loading...

ps/trunk/source/graphics/MiniMapTexture.cpp

Loading...

ps/trunk/source/graphics/ParticleEmitter.cpp

Loading...

ps/trunk/source/graphics/ShaderProgram.h

Loading...

ps/trunk/source/graphics/TextRenderer.cpp

Loading...

ps/trunk/source/gui/ObjectTypes/CMiniMap.cpp

Loading...

ps/trunk/source/ps/Profiler2GPU.cpp

Loading...

ps/trunk/source/ps/Profiler2GPU.h

Loading...

ps/trunk/source/renderer/DebugRenderer.cpp

Loading...

ps/trunk/source/renderer/DecalRData.cpp

Loading...

ps/trunk/source/renderer/HWLightingModelRenderer.cpp

Loading...

ps/trunk/source/renderer/HWLightingModelRenderer.h

Loading...

ps/trunk/source/renderer/InstancingModelRenderer.cpp

Loading...

ps/trunk/source/renderer/InstancingModelRenderer.h

Loading...

ps/trunk/source/renderer/ModelRenderer.cpp

Loading...

ps/trunk/source/renderer/ModelVertexRenderer.h

Loading...

ps/trunk/source/renderer/OverlayRenderer.cpp

Loading...

ps/trunk/source/renderer/ParticleRenderer.cpp

Loading...

ps/trunk/source/renderer/PatchRData.cpp

Loading...

ps/trunk/source/renderer/PostprocManager.cpp

Loading...

ps/trunk/source/renderer/ShadowMap.cpp

Loading...

ps/trunk/source/renderer/SilhouetteRenderer.cpp

Loading...

ps/trunk/source/renderer/SkyManager.cpp

Loading...

ps/trunk/source/renderer/TerrainOverlay.cpp

Loading...

ps/trunk/source/renderer/TerrainRenderer.cpp

Loading...

ps/trunk/source/renderer/TexturedLineRData.cpp

Loading...

ps/trunk/source/renderer/VertexArray.cpp

Loading...

ps/trunk/source/renderer/VertexArray.h

Loading...

ps/trunk/source/renderer/VertexBuffer.cpp

Loading...

ps/trunk/source/renderer/VertexBuffer.h

Loading...

ps/trunk/source/renderer/WaterManager.cpp

Loading...

ps/trunk/source/renderer/backend/IShaderProgram.h

Loading...

ps/trunk/source/renderer/backend/gl/DeviceCommandContext.cpp

Loading...

ps/trunk/source/renderer/backend/gl/DeviceCommandContext.h

Loading...

ps/trunk/source/renderer/backend/gl/ShaderProgram.cpp

Loading...

ps/trunk/source/renderer/backend/gl/ShaderProgram.h

Loading...