Adds AsFloatArray to CMatrix3D.
Description
Description
Details
Details
- Committed
vladislavbelov Apr 27 2022, 9:53 PM - Parents
- rP26833: Adds backend buffer upload forgotten in rP26815. Fixes #6520
- Branches
- Unknown
- Tags
- Build Status
Buildable 20197 Build 48538: Trigger Windows Autobuild Build 48537: Post-Commit Build Jenkins Build 48536: Post-Commit Build (macOS) Jenkins
Event Timeline
/ps/trunk/source/renderer/backend/gl/ShaderProgram.cpp | ||
---|---|---|
779 | Weird to name a matrix v, shouldn't it be m ? |
/ps/trunk/source/renderer/backend/gl/ShaderProgram.cpp | ||
---|---|---|
779 | I suppose it was just copy-pasted from other methods. Anyway it'll be removed in the next patch. |
Comment Actions
Why are so many CMatrix3D fonctions defined in the header?
/ps/trunk/source/maths/Matrix3D.h | ||
---|---|---|
326 | information about the size is lost e.g. return const std::array<float,16>& |
Comment Actions
Helping inline for compilers without LTO.
/ps/trunk/source/maths/Matrix3D.h | ||
---|---|---|
326 |
std::array isn't a proper container here. I'll add PS::span in the next patch. |
Comment Actions
Which is to say -> making those functions inlinable (in turn, allowing cascading optimisations), since we don't use LTO on any official compilation pipeline.
Comment Actions
I'd start from enabling LTO (LGTC) for MSVC, should be easy to check without side effects.