Diffusion 0 A.D. Public Repository rP26986

[GUI] increase msgbox button size to fix text overlap
rP26986
Actions

Description

[GUI] increase msgbox button size to fix text overlap

Report: https://wildfiregames.com/forum/topic/82754-alpha-26-pre-releaserelease-candidate-build-testing/page/6/#comment-504135

rP25978 added a new button which has more text and can span have multiple lines in some languages.
Fix: increase the size.
possible todo for the future: unify button sizes or make them adaptive depending on the text size.

comments by @Langbart @Stan

accepted by @wraitii

Differential revision: https://code.wildfiregames.com/D4707

Details

Auditors

Stan

Committed

marder

Jun 24 2022, 1:19 PM

Differential Revision

D4707: [GUI] increase msgbox button size to fix text overlap

Parents

rP26985: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 20587
Build 49629: Post-Commit Build	Jenkins
Build 49628: Post-Commit Build (macOS)	Jenkins

Event Timeline

marder committed rP26986: [GUI] increase msgbox button size to fix text overlap.Jun 24 2022, 1:19 PM

marder added an edge: D4707: [GUI] increase msgbox button size to fix text overlap.

marder added subscribers: Langbart, Stan, wraitii.

Harbormaster completed building B20587: rP26986: [GUI] increase msgbox button size to fix text overlap.Jun 24 2022, 1:38 PM

I have to say that I am very disappointed with the decision to proceed with this patch. Detailed comments were simply ignored I will definitely not continue to work on this project if this carries on.

09:06 wraitii I think this is a strong 'who the f cares' situation

Comments like this make clear why former participants have left the project.

Can we mitigate this? Now that we have a new RB we gained more time to fix things better.

Too big buttons

Reset option
ScenarioEditor
Unsaved options
Multiplayer lobby (create new account / login)
Basically any small popup? Hopefully one change for all?

Mod loader seems unaffected. Actually it doesn't even seem to work there ?

Comments like this make clear why former participants have left the project.

That's an oversimplification of what happened though.

This commit now has outstanding concerns.Jun 24 2022, 5:36 PM

@Langbart I am sorry, but don't think I understand.
I agree with you comments on the patch ( didn't ignore your comments on purpose/ thought I addressed them by replying on the diff that this should be done ), the only problem is that I have no time to do it the way you described right now and so the question for me was: rather have inconsistent button sizes or overlapping text for the next release.
Maybe I misunderstood your comments/ didn't wait long enough in case you wanted to comment again, but given these two options, would you rather have overlapping text ?

@Stan sure, easiest thing is to just revert this.
The only problem is that it takes time to do all the points @Langbart mentioned and to go through all the buttons and make sure nothing overlaps / everything is correct.

marder mentioned this in rP26987: revert last commit / rP26986.Jun 24 2022, 6:42 PM

Stan resigned from this commit.Jun 26 2022, 6:08 PM

This commit no longer requires audit.Jun 26 2022, 6:08 PM

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

mod/

gui/

common/

utilities.js

rP26986

View Options

ps/trunk/binaries/data/mods/mod/gui/common/utilities.js