HomeWildfire Games
Diffusion 0 A.D. Public Repository rP27241

Don't (mis)use technologies to differentiate elephants.
rP27241
Actions

Description

Don't (mis)use technologies to differentiate elephants.

Use mixins.

Differential revision: D4590

Details

Committed
FreagarachNov 22 2022, 8:09 AM
Differential Revision
D4590: Don't (mis)use technologies to differentiate elephants.
Parents
rP27240: Add TerritoryInfluence to Athenian Gymnasium.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21103
Build 51038: Post-Commit BuildJenkins
Build 51037: Post-Commit Build (macOS)Jenkins

Event Timeline

Freagarach committed rP27241: Don't (mis)use technologies to differentiate elephants..Nov 22 2022, 8:09 AM
Freagarach added an edge: D4590: Don't (mis)use technologies to differentiate elephants..
Harbormaster completed building B21103: rP27241: Don't (mis)use technologies to differentiate elephants..Nov 22 2022, 8:48 AM
Freagarach added a comment.Nov 24 2022, 8:58 AM

#6659, but I'm a bit lost why,,, It works fine for mercenaries.

Stan added a subscriber: Stan.Nov 24 2022, 9:01 AM

Maybe because of the order of templates?

Langbart added a subscriber: Langbart.EditedNov 24 2022, 9:55 AM
In rP27241#59224, @Freagarach wrote:

#6659, but I'm a bit lost why,,, It works fine for mercenaries.

When I do this, I no longer get errors.

--- a/binaries/data/mods/public/simulation/templates/template_unit_champion_elephant.xml
+++ b/binaries/data/mods/public/simulation/templates/template_unit_champion_elephant.xml
@@ -3,10 +3,6 @@
   <Cost>
     <Population>3</Population>
     <BuildTime>36</BuildTime>
-    <Resources>
-      <food>300</food>
-      <metal>200</metal>
-    </Resources>
   </Cost>
   <Footprint replace="">
     <Square width="4.5" depth="9.0"/>
@@ -19,11 +15,6 @@
     <GenericName>War Elephant</GenericName>
     <VisibleClasses datatype="tokens">Elephant</VisibleClasses>
   </Identity>
-  <Loot>
-    <xp>300</xp>
-    <food>30</food>
-    <metal>20</metal>
-  </Loot>
   <Position>
     <TurnRate>4</TurnRate>
   </Position>

(🌵 not a solution)

Freagarach mentioned this in D4832: Fix elephant mixins..Nov 24 2022, 10:13 AM
Langbart added a comment.EditedNov 24 2022, 10:28 AM

replace op="mul" with op="mul_round" ?

--> rP25245

EDIT:

Freagarach added a comment.Nov 24 2022, 10:31 AM

"a fox is not caught twice in the same snare" -- not true apparently. ;(

Freagarach mentioned this in D4584: [WIP] - Technologies to templates..Mar 31 2023, 9:29 AM

Changes (10)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
data/
technologies/
templates/
mixins/
units/
cart/
kush/
maur/
pers/
ptol/
sele/

rP27241

View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/unit_elephant_african.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/unit_elephant_indian.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/mixins/elephant_african.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/mixins/elephant_indian.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/cart/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/kush/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/maur/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/pers/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/ptol/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/sele/champion_elephant.xml

Loading...
Wildfire Games · Phabricator