Diffusion 0 A.D. Public Repository rP27277

Additional default colors after D4811
Concern RaisedrP27277
Actions

Description

Additional default colors after D4811

Comment by: Stan

Fixes: #3506
Differential Revision: https://code.wildfiregames.com/D4813

Details

Auditors

vladislavbelov

Committed

trompetin17

Dec 6 2022, 10:19 PM

Parents

rP27276: Fixes missing svn:eol-style native for debug_fragment.h and solid.vs.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 21165
Build 51209: Post-Commit Build	Jenkins
Build 51208: Post-Commit Build (macOS)	Jenkins

Event Timeline

trompetin17 committed rP27277: Additional default colors after D4811.Dec 6 2022, 10:19 PM

Harbormaster completed building B21165: rP27277: Additional default colors after D4811.Dec 6 2022, 10:31 PM

The commit makes impossible to change colors and algorithm to pick a more distant one separately.

This commit now has outstanding concerns.Dec 7 2022, 4:32 AM

In rP27277#59332, @vladislavbelov wrote:

The commit makes impossible to change colors and algorithm to pick a more distant one separately.

mind if you help me to see what are you seeing, and test guidance?

In rP27277#59335, @trompetin17 wrote:

mind if you help me to see what are you seeing, and test guidance?

Sure! Answered in the diff.

I'm not sure now does my concern have to be interepreted as a real concern or more as a attention attraction.

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gamesettings/

attributes/

PlayerColor.js

rP27277

View Options

ps/trunk/binaries/data/mods/public/gamesettings/attributes/PlayerColor.js