HomeWildfire Games
Diffusion 0 A.D. Public Repository rP27399

Switch default behavior from capture to attack.
rP27399
Actions

Description

Switch default behavior from capture to attack.

Discussed countless times on the forum.
We try this out this release.

Patch by: @marder
Differential revision: https://code.wildfiregames.com/D4697
Idea accepted by: @asterix, @wowgetoffyourcellphone, @chrstgtr
Comments by: ^ + @Stan

Details

Auditors
Stan
Committed
FreagarachJan 9 2023, 3:29 PM
Differential Revision
D4697: [Gameplay] Switch default behavior from capture to attack
Parents
rP27398: Optional column "sort_order" attribute support olist GUI
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21377
Build 51800: Post-Commit BuildJenkins
Build 51799: Post-Commit Build (macOS)Jenkins

Event Timeline

Freagarach committed rP27399: Switch default behavior from capture to attack..Jan 9 2023, 3:29 PM
Freagarach added an edge: D4697: [Gameplay] Switch default behavior from capture to attack.
Freagarach added subscribers: marder, chrstgtr, asterix and 2 others.
Harbormaster completed building B21377: rP27399: Switch default behavior from capture to attack..Jan 9 2023, 3:59 PM
wowgetoffyourcellphone awarded a token.Jan 9 2023, 4:08 PM

Based.

Stan raised a concern with this commit.Jan 11 2023, 8:01 AM
Stan added a subscriber: minohaka.
In D4697#208585, @minohaka wrote:
In D4697#208133, @Freagarach wrote:
In D4697#208094, @asterix wrote:

I still agree with this change that for new players it is actually better, what about the linter warnings?

You can help by testing the pach for errors.

  • Does patrolling still function?
  • Can one attack-move and do units show the expected behaviour?
  • Is it still possible to capture targets?

No longer possible to capture targets, might be related to this line (337 default.cfg):

attackmove = Ctrl            ; Modifier to attackmove when clicking on a point
This commit now has outstanding concerns.Jan 11 2023, 8:01 AM
Freagarach mentioned this in rP27412: Adds Vulkan backend..Jan 11 2023, 8:15 AM
Freagarach requested verification of this commit.

It wasn't me. ;)
rP27412

This commit now requires verification by auditors.Jan 11 2023, 8:16 AM
Stan resigned from this commit.Jan 11 2023, 8:44 AM

Sweet :) Thanks for the fast check :)

This commit no longer requires audit.Jan 11 2023, 8:44 AM
Freagarach mentioned this in D4908: Use different hotkey for capturing by default..Jan 23 2023, 11:03 AM
Freagarach mentioned this in rP27506: Use different default hotkey for capturing..Jan 30 2023, 9:17 AM
Freagarach mentioned this in D4933: Fix rally points cursor and capturing from spawn..Feb 9 2023, 8:53 AM
Freagarach mentioned this in rP27532: Fix idle units idling nigh capturable entity..Feb 10 2023, 8:20 AM
Freagarach mentioned this in rP27533: Fix rally point cursor and capturing from spawn..

Changes (6)

PathSize
ps/
trunk/
binaries/
data/
config/
mods/
public/
gui/
hotkeys/
spec/
manual/
session/
simulation/
components/
helpers/

rP27399

View Options

ps/trunk/binaries/data/config/default.cfg

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/hotkeys/spec/ingame.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/manual/intro.txt

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Commands.js

Loading...
Wildfire Games ยท Phabricator