Diffusion 0 A.D. Public Repository rP27442

Fix a bug with Python >= 3.11 where -rU was removed as an open flag.
AuditedrP27442
Actions

Description

Fix a bug with Python >= 3.11 where -rU was removed as an open flag.
Patch by: @sera
Refs #6676 Phab:rP27409
Differential Revision: https://code.wildfiregames.com/D4888

Details

Auditors

sera

Committed

Stan	Jan 14 2023, 1:22 PM

Differential Revision

D4888: spidermonky python 3.11 support wrt universal newline

Parents

rP27441: Fix a case sensitive issue on macOS. macOS usually do not use a case sensitive…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 21458
Build 52028: Post-Commit Build	Jenkins
Build 52027: Post-Commit Build (macOS)	Jenkins

Event Timeline

Stan committed rP27442: Fix a bug with Python >= 3.11 where -rU was removed as an open flag..Jan 14 2023, 1:22 PM

Stan added an edge: D4888: spidermonky python 3.11 support wrt universal newline.

Stan added a subscriber: sera.

Harbormaster completed building B21458: rP27442: Fix a bug with Python >= 3.11 where -rU was removed as an open flag..Jan 14 2023, 2:06 PM

sera raised a concern with this commit.Jan 14 2023, 9:54 PM

sera added inline comments.

/ps/trunk/libraries/source/spidermonkey/patch.sh
40	Erm, my bad. When adding the version check seems I managed to change the patch to be applied

This commit now has outstanding concerns.Jan 14 2023, 9:54 PM

Stan added inline comments.Jan 14 2023, 9:55 PM

/ps/trunk/libraries/source/spidermonkey/patch.sh
40	I think it's me not sure. Fixed few mins ago

Stan marked an inline comment as done.Jan 14 2023, 9:55 PM

Oh, already noticed by Itms :)

All concerns with this commit have now been addressed.Jan 14 2023, 9:55 PM

Changes (2)

Path

Size

ps/

trunk/

libraries/

source/

spidermonkey/

Fix-use-of-removed-U-support-in-python-3.11.patch

patch.sh

rP27442

View Options

ps/trunk/libraries/source/spidermonkey/Fix-use-of-removed-U-support-in-python-3.11.patch