Follow proper Shutdown sequence when using -dumpSchema, fixes #6696.
Also fix an incorrect code comment, and prevent Atlas from being started with -dumpSchema.
Reviewed By: phosit
Differential Revision: https://code.wildfiregames.com/D4903
Description
Description
Details
Details
- Provenance
Itms Authored on - Reviewer
- phosit
- Differential Revision
- D4903: Follow proper Shutdown sequence when using -dumpSchema
- Parents
- rP27469: Fix FMT and NVTT not linking with the correct SDK.
- Branches
- Unknown
- Tags
- Build Status
Buildable 21521 Build 52203: Trigger Windows Autobuild Build 52202: Post-Commit Build Jenkins Build 52201: Post-Commit Build (macOS) Jenkins
Event Timeline
| /ps/trunk/source/ps/GameSetup/GameSetup.cpp | ||
|---|---|---|
| 599 | Inconsistent logging function, LOGERROR is used above. If indeed LOGERROR can't be used then it's an implicit relation to the context. | |
| /ps/trunk/source/ps/GameSetup/GameSetup.cpp | ||
|---|---|---|
| 599 | Hi, this message is not an error. It's just an information that is mostly interesting for debug purposes (since users expect the file to be generated when they run the program with dumpSchema). This is why I used debug_printf. | |
| /ps/trunk/source/ps/GameSetup/GameSetup.cpp | ||
|---|---|---|
| 599 | Then it could be replaced by LOGMESSAGE else the message won't be printed on Windows and won't be in logs. | |
| /ps/trunk/source/ps/GameSetup/GameSetup.cpp | ||
|---|---|---|
| 599 | LOGMESSAGE does not print to stdout. | |
| /ps/trunk/source/ps/GameSetup/GameSetup.cpp | ||
|---|---|---|
| 599 | LOGMESSAGERENDER does. | |
| /ps/trunk/source/ps/GameSetup/GameSetup.cpp | ||
|---|---|---|
| 599 | No | |