fix VFS real path retrieval for files mounted from multiple directories (e.g.
rP8082
Actions

Description

fix VFS real path retrieval for files mounted from multiple directories (e.g. mods)
closes #564
GetRealPath was too simplistic and just asked the directory *most recently mounted* into the file's VFS directory for its path. the correct solution is to ask the file's loader for its path. the archiver IFileLoader new returns the archive's pathname as the real path.
also simplified VfsFile's interface.

Details

Committed

jan	Sep 5 2010, 11:41 PM

Parents

rP8081: Fixed main menu parchment buttons (Fixes #561)

Branches

Unknown

Tags

Unknown

Reverted By

rP25107: Make real directory paths on the VFS predictable (retry)
D3728: D3217 #2 - Make real directory paths on the VFS predictable.
rP25104: Make real directory paths on the VFS predictable.
D3217: Fix writing mod data.

Event Timeline

jan committed rP8082: fix VFS real path retrieval for files mounted from multiple directories (e.g..Sep 5 2010, 11:41 PM

wraitii added a subscriber: wraitii.Dec 13 2020, 1:39 PM

wraitii added inline comments.

/ps/trunk/source/lib/file/vfs/vfs.cpp
175	This should probably have renamed the function to something else, particularly since in rP10454 GetDirectoryRealPath was added, and we had the situation where `GetRealPath(file) != GetDirectoryRealPath(parent) / filename`, which is extra confusing.