HomeWildfire Games
Diffusion 0 A.D. Public Repository rP8218

Fix CStr parsing to be independent of locale, so that it doesn't break when…
AuditedrP8218
Actions

Description

Fix CStr parsing to be independent of locale, so that it doesn't break when GTK+ changes the locale.

Details

Auditors
wraitii
Committed
philipOct 1 2010, 1:17 AM
Parents
rP8217: More GUI fixes. Specifically, making panel textures size appropriately in…
Branches
Unknown
Tags
Unknown

Event Timeline

philip committed rP8218: Fix CStr parsing to be independent of locale, so that it doesn't break when….Oct 1 2010, 1:17 AM
wraitii raised a concern with this commit.Jun 16 2019, 11:45 AM
wraitii added a subscriber: wraitii.

Parsing of "3bogus" is different on libstd and libc, see debates starting in 2013 here: https://bugs.llvm.org/show_bug.cgi?id=17782

This commit now has outstanding concerns.Jun 16 2019, 11:45 AM
wraitii added a comment.Jun 16 2019, 12:09 PM

See D1988.

historic_bruno mentioned this in D2101: Re-D2013 - Fix incorrect use of setlocale() in cppformat CStr tests.Jul 21 2019, 5:40 PM
wraitii accepted this commit.Jul 27 2020, 10:08 AM

Fixed by rP22908

All concerns with this commit have now been addressed.Jul 27 2020, 10:08 AM

Changes (2)

PathSize
ps/
trunk/
source/
ps/
tests/

rP8218

View Options

ps/trunk/source/ps/CStr.cpp

Loading...
View Options

ps/trunk/source/ps/tests/test_CStr.h

Loading...
Wildfire Games · Phabricator