HomeWildfire Games

Import original OgreGLSLProcessor from OGRE 1.7.2

Description

Import original OgreGLSLProcessor from OGRE 1.7.2

Details

Committed
philipMar 26 2011, 9:07 PM
Parents
rP9120: broken rope bridge eyecandy object added
Branches
Unknown
Tags
Unknown

Event Timeline

Stan added a subscriber: Stan.Sep 29 2019, 11:58 AM
Stan added inline comments.
/ps/trunk/source/ps/Preprocessor.cpp
941

According to sonar this UB: 'Shifting signed value by too many bits is undefined behaviour.'
CWE-758: Reliance on Undefined, Unspecified, or Implementation-Defined Behavior

elexis added a subscriber: elexis.Sep 29 2019, 12:26 PM

Perhaps that fixes it, I have no clue what that code is supposed to do and never read it.

So this is basically an excerpt of a third party lib, so it sounds like it should become part of the third-party-lib-maintenance cycle of the ReleaseProcessDraft, moved to source/third-party/, also perhaps a LICENSE.txt reference inserted.

The bitshift is still unmodified in OGRE:
https://github.com/OGRECave/ogre/blob/master/RenderSystems/GLSupport/src/GLSL/OgreGLSLPreprocessor.cpp#L1000

So it could be reported upstream at https://github.com/OGRECave/ogre/issues (is that even the right repo?),
or rather at https://github.com/OGRECave/ogre-next if I read https://www.ogre3d.org/2019/09/22/improvements-in-vr-morph-animations-moving-to-github-and-ci

Otherwise there was a managable amount of updates to this file that we might want to pull:
https://code.wildfiregames.com/P180