Change Details

rP22693 introduced a non-copying GetSetting variant, since using GetSettingPointer is ugly and since GetSetting performs a copy when a reference is sufficient and more performant for non-primitives. GetSetting returning a reference has the advantage that one can collapse a bunch of code, one can inline the function call. So one doesnt have to declare a variable, assign the default value, then assign the setting value, and then use the setting value but can do it all in one step. Another advantage of the new variant, as revealed by this patch, is that it shows some unused variables whereas before it didn't. Since the new GetSetting can do everything the previous GetSetting can do but in better, this patch removes the old function variant. Another advantage is that the variables can become constants. This patch avoids many copies of CStr and CStrW, even for Draw calls.

rP22693 introduced a non-copying GetSetting variant, since using GetSettingPointer is ugly and since GetSetting performs a copy when a reference is sufficient and more performant for non-primitives. GetSetting returning a reference has the advantage that one can collapse a bunch of code, one can inline the function call. So one doesnt have to declare a variable, assign the default value, then assign the setting value, and then use the setting value but can do it all in one step. Another advantage of the new variant, as revealed by this patch, is that it shows some unused variables whereas before it didn't. Since the new GetSetting can do everything the previous GetSetting can do but in better, this patch removes the old function variant. Another advantage is that the variables can become constants. This patch avoids many copies of CStr and CStrW, even for Draw calls. (This GetSetting variant might have been a nicer fix than rP1518.)

rP22693 introduced a non-copying GetSetting variant, since using GetSettingPointer is ugly and since GetSetting performs a copy when a reference is sufficient and more performant for non-primitives. GetSetting returning a reference has the advantage that one can collapse a bunch of code, one can inline the function call. So one doesnt have to declare a variable, assign the default value, then assign the setting value, and then use the setting value but can do it all in one step. Another advantage of the new variant, as revealed by this patch, is that it shows some unused variables whereas before it didn't. Since the new GetSetting can do everything the previous GetSetting can do but in better, this patch removes the old function variant. Another advantage is that the variables can become constants. This patch avoids many copies of CStr and CStrW, even for Draw calls. (This GetSetting variant might have been a nicer fix than rP1518.)