This follows rP24675.
Hotkeys are currently re-triggered when releasing a key. This leads to two issues:
- First of all, it's bugged - it only retriggers one matching key in SVN (see below).
- Secondly, it's somewhat unexpected: there is a 'press' despite it being a key release.
These fixes these issues: Press, Up are sent only on a 'positive' key press.
TODOs & questions:
- Should 'Down' still be sent? This is the 'repeating' event.
- Implement a way for JS scripts to still subscribe to 'silent' event, should they want to.
- Hotkey 'press' is not sending 'hotkeypress' but 'press' to scripts, which seems awkward (see control group code).
- Actually fix control groups.