Change Details

Currently we use a wide variety of timers on windows. HPET nearly often fails to initialize because it requires admin rights. The fallback is usually TSC which is an usually reliable timer, that unfortunately seems to have some issues on the latest Ryzen CPUS. This patch force QPC usage. This way all platforms can run the game the same way. It should not have a big performance impact as computers are way faster than they used to 10 years ago. Ideally we'd find a better way to handle those cases but this is patch is in case we don't find a better solution for A24

Currently we use a wide variety of timers on windows. HPET nearly often fails to initialize because it requires admin rights. The fallback is usually TSC which is an usually reliable timer, that unfortunately seems to have some issues on the latest Ryzen CPUS. This patch force QPC usage. This way all platforms can run the game the same way. It should not have a big performance impact as computers are way faster than they used to 10 years ago. Ideally we'd find a better way to handle those cases but this is patch is in case we don't find a better solution for A24 All the other big engines also use QPC - [[ https://github.com/godotengine/godot/blob/24e1039eb6fe32115e8d1a62a84965e9be19a2ed/thirdparty/vhacd/inc/vhacdTimer.h | Godot ]] - [[ https://github.com/OGRECave/ogre-next/blob/4af1f49f4d8e3475084294b386f693ca616b0292/OgreMain/src/WIN32/OgreTimer.cpp | Ogre 3D ]] - [[ https://github.com/spring/spring/blob/99610465a23c2102feb7b871512cec7b86c21ee9/rts/System/Misc/SpringTime.cpp | Spring ]] - [[ https://github.com/zaki/irrlicht/blob/1b0e050d90f280507ff248fc85897efe6737a13c/source/Irrlicht/os.cpp | Irrlicht ]] - [[ https://github.com/supertuxkart/stk-code/blob/f89933bb46d504dcfaa620e4d06e6407b524a4a5/lib/wiiuse/src/os_win.c |STK (Irrlicht) ]] According to this [[ https://www.reddit.com/r/DestinyTechSupport/comments/ehmnh1/weekly_reminder_destiny_2_troubleshooting_guides/ | post ]] on Reddit > Windows will use HPET if required, generally games use QueryPerformanceCounter (QPC) and Windows 10 will use the fastest timer available e.g Invariant TSC (ITSC) or Time Stamp Counter (TSC). Default settings for Windows 10 is HPET available ( not disabled ) and other timers available ( not disabled ) I will post the discussion with @janwas after cleaning it a bit. See also the discussion [[ http://irclogs.wildfiregames.com/2020-05/2020-05-08-QuakeNet-%230ad-dev.log | here ]] I also made a post [[ https://www.reddit.com/r/AMDHelp/comments/gfq9vu/does_anyone_have_experience_about_cpu_timers_on/ | here ]] no answers yet. The mail exchange with AMD currently lead [[ https://wildfiregames.com/forum/index.php?/topic/26890-problem-with-ryzen-3000er-series/page/3/ | nowhere ]].

Currently we use a wide variety of timers on windows. HPET nearly often fails to initialize because it requires admin rights. The fallback is usually TSC which is an usually reliable timer, that unfortunately seems to have some issues on the latest Ryzen CPUS. This patch force QPC usage. This way all platforms can run the game the same way. It should not have a big performance impact as computers are way faster than they used to 10 years ago. Ideally we'd find a better way to handle those cases but this is patch is in case we don't find a better solution for A24 All the other big engines also use QPC - [[ https://github.com/godotengine/godot/blob/24e1039eb6fe32115e8d1a62a84965e9be19a2ed/thirdparty/vhacd/inc/vhacdTimer.h | Godot ]] - [[ https://github.com/OGRECave/ogre-next/blob/4af1f49f4d8e3475084294b386f693ca616b0292/OgreMain/src/WIN32/OgreTimer.cpp | Ogre 3D ]] - [[ https://github.com/spring/spring/blob/99610465a23c2102feb7b871512cec7b86c21ee9/rts/System/Misc/SpringTime.cpp | Spring ]] - [[ https://github.com/zaki/irrlicht/blob/1b0e050d90f280507ff248fc85897efe6737a13c/source/Irrlicht/os.cpp | Irrlicht ]] - [[ https://github.com/supertuxkart/stk-code/blob/f89933bb46d504dcfaa620e4d06e6407b524a4a5/lib/wiiuse/src/os_win.c |STK (Irrlicht) ]] According to this [[ https://www.reddit.com/r/DestinyTechSupport/comments/ehmnh1/weekly_reminder_destiny_2_troubleshooting_guides/ | post ]] on Reddit > Windows will use HPET if required, generally games use QueryPerformanceCounter (QPC) and Windows 10 will use the fastest timer available e.g Invariant TSC (ITSC) or Time Stamp Counter (TSC). Default settings for Windows 10 is HPET available ( not disabled ) and other timers available ( not disabled ) I will post the discussion with @janwas after cleaning it a bit. See also the discussion [[ http://irclogs.wildfiregames.com/2020-05/2020-05-08-QuakeNet-%230ad-dev.log | here ]] I also made a post [[ https://www.reddit.com/r/AMDHelp/comments/gfq9vu/does_anyone_have_experience_about_cpu_timers_on/ | here ]] no answers yet. The mail exchange with AMD currently lead [[ https://wildfiregames.com/forum/index.php?/topic/26890-problem-with-ryzen-3000er-series/page/3/ | nowhere ]].