Disclaimer: I switched to use git instead of svn, and this is the first patch that uses this workflow. I kind of expect something to go wrong.
____
This is basically the extension of @andy5995 's D4303 and @lyv 's D4670
Note that while this diff is rather big, I have this locally as 5 separate commits, I just didn't read that much into how I can export them separately and stack diffs here. But if @lyv is very interested to see them I can investigate how to do that.
____
This patch:
* moves the placement functions and the getTeamArray from rmgen2 to rmgen1
* (soft) deprecates `createBasesByPattern` in rmgen2
* introduces a new rmgen1 function `playerPlacementByPattern` that takes over this functionality
* introduces a new function to check if it is safe to place the starting walls
* cleans up the naming of the teamplacement options
* fixes a bug in game setting for the teamplacement -> the random option was not correctly chosen
and finally (why I did all this/ after so many people in the forums expressed interest in this)
it gives more placement options to good old mainland.
Note: The placement options can now be extended to many rmgen1 maps.